Commit Graph

4311 Commits

Author SHA1 Message Date
Jaime Piña
de105a0a4e Return not ready for connection reason
Currently, we use ReadyForConnections in server tests to wait for the
server to be ready. However, when this fails we don't get a clue about
why it failed.

This change adds a new unexported method called readyForConnections that
returns an error describing which check failed. The exported
ReadyForConnections version works exactly as before. The unexported
version gets used in internal tests only.
2021-04-19 17:15:42 -07:00
Derek Collison
8f07929530 2.2.2-beta.5
Signed-off-by: Derek Collison <derek@nats.io>
2021-04-15 17:35:28 -07:00
Matthias Hanel
b3e355c263 [fixed] sub ref count issue across leaf node connections
This was caused by not sending subs across leaf node connections in some
cases but sending unsub in all cases. This imbalance caused
subscriptions to go away too soon. (ref count was off)

Signed-off-by: Matthias Hanel <mh@synadia.com>
2021-04-15 20:13:57 -04:00
Derek Collison
35bf0e8ce5 Merge pull request #2122 from nats-io/cleanup_tests
Cleanup some tests + GetTLSConnectionState() race fix
2021-04-15 13:57:51 -07:00
Ivan Kozlovic
7964f57236 Merge pull request #2123 from nats-io/fix_gw_si
Do not propagate service import interest across GW and ROUTES
2021-04-15 12:06:07 -06:00
Ivan Kozlovic
6e1205b660 Cleanup some tests + GetTLSConnectionState() race fix
Missing defers

Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
2021-04-15 11:37:43 -06:00
Derek Collison
c5917756eb Merge pull request #2121 from nats-io/mb-close-fix
js: msgblock close fix
2021-04-15 10:36:15 -07:00
Ivan Kozlovic
56d0d9ec87 Do not propagate service import interest across GW and ROUTES
Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
2021-04-15 11:34:36 -06:00
Derek Collison
311b3cd701 Merge pull request #2120 from nats-io/flapper
Fix for flapping test
2021-04-15 10:30:56 -07:00
Waldemar Quevedo
2976a78f57 js: msgblock close fix
Also swaps order of cleaning up resource directory in cluster tests.
2021-04-15 09:16:02 -07:00
Derek Collison
f3f04e6442 Fix flapper
Signed-off-by: Derek Collison <derek@nats.io>
2021-04-15 06:34:12 -07:00
Derek Collison
14627434c9 Bump Version
Signed-off-by: Derek Collison <derek@nats.io>
2021-04-15 04:53:27 -07:00
Derek Collison
eadd070009 Merge pull request #2119 from nats-io/peer_state
Do not limit expansion of new peers
2021-04-15 04:52:17 -07:00
Derek Collison
8e82f36c5b Track removed peers properly
Signed-off-by: Derek Collison <derek@nats.io>
2021-04-14 20:29:09 -07:00
Derek Collison
cf34514f9f Do not limit expansion of new peers
Signed-off-by: Derek Collison <derek@nats.io>
2021-04-14 18:47:11 -07:00
Ivan Kozlovic
c92cb97ac7 Merge pull request #2117 from nats-io/fix-fail-parent-test
Fix calling FailNow in parent test
2021-04-14 16:47:24 -06:00
Derek Collison
564d41217a Merge pull request #2118 from nats-io/source_sub
Cleanup request subscription if no answer
2021-04-14 15:07:03 -07:00
Derek Collison
466789e307 Cleanup request subscription if no answer
Signed-off-by: Derek Collison <derek@nats.io>
2021-04-14 15:04:22 -07:00
Jaime Piña
1ccb5572ba Fix calling FailNow in parent test
Currently, TestJetStreamClusterMirrorExpirationAndMissingSequences calls
FailNow from the parent test when a subtest fails. This causes an error.

This change calls FailNow to fail the subtest from the subtest itself.
2021-04-14 14:45:11 -07:00
Derek Collison
d04c1f8e29 Merge pull request #2116 from nats-io/mirror_hbs
Allow control messages like heartbeats to pass the old sub test.
2021-04-14 14:12:53 -07:00
Derek Collison
395728bab9 Allow control messages like heartbeats to pass the old sub test.
Signed-off-by: Derek Collison <derek@nats.io>
2021-04-14 14:11:02 -07:00
Derek Collison
ee1775c667 Merge pull request #2111 from nats-io/peers
Add in more extensive test on extending hubs with leafnode clusters
2021-04-14 10:48:48 -07:00
Derek Collison
2ef2473582 Merge pull request #2113 from nats-io/mirrors
Make sure to stop unneeded retries for mirror consumers.
2021-04-14 10:46:50 -07:00
Derek Collison
627d20f7d4 Make sure to stop retries for mirror consumers when not leader and through old control messages.
Signed-off-by: Derek Collison <derek@nats.io>
2021-04-14 10:43:55 -07:00
Derek Collison
1127c5d771 Bump Version
Signed-off-by: Derek Collison <derek@nats.io>
2021-04-13 20:08:29 -07:00
Derek Collison
6ca6db70b2 Add in more extensive test on extending hubs with leafnode clusters
Signed-off-by: Derek Collison <derek@nats.io>
2021-04-13 19:55:41 -07:00
Derek Collison
f1e16fa796 Merge pull request #2110 from nats-io/mirror_expire
Mirrors failed when upstream messages had expired.
2021-04-13 12:31:02 -07:00
Derek Collison
f6a82a7c98 When messages were no longer available in an upstream stream a mirror could wedge and not resolve.
This fixes that scenario by detecting the situation and inserting skip msgs to catch up.

Signed-off-by: Derek Collison <derek@nats.io>
2021-04-13 11:46:03 -07:00
Derek Collison
5696358494 Merge pull request #2109 from nats-io/deleted_details
Change to report total deleted by default for stream info.
2021-04-13 07:54:32 -07:00
Derek Collison
90989d57d6 Change to report total deleted by default for stream info.
Allow deleted details if requested.

Signed-off-by: Derek Collison <derek@nats.io>
2021-04-12 18:10:11 -07:00
Derek Collison
6788c757d1 Merge pull request #2108 from nats-io/lnjs
Improve JS when a leafnode cluster extends and shares a system account.
2021-04-12 17:24:13 -07:00
Matthias Hanel
9486722e96 [fixing] subscription issue when subscribing to a super set of deny_import
If the subscription was foo. > but the server also had an import deny of foo.bar
It was legal to send the subscription. But the other server was unaware
of the restriction and sent the message anyway. The check of the
incoming message did not happen.

Fixing by ignoring messages the server is not supposed to receive.
And exchange deny_import so that the non soliciting leaf node knows to not
send these messages in the first place.

NB. merging of deny_ export/import with perms from INFO happens in processLeafnodeInfo

Signed-off-by: Matthias Hanel <mh@synadia.com>
2021-04-12 20:09:55 -04:00
Derek Collison
755ef74855 When a cluser of leafnodes connects to a cluster or supercluster hub and they share the system account make the leafnode servers observers.
Signed-off-by: Derek Collison <derek@nats.io>
2021-04-12 17:00:55 -07:00
Derek Collison
8645935ccd Bump version
Signed-off-by: Derek Collison <derek@nats.io>
2021-04-12 11:43:11 -07:00
Derek Collison
e00cbf4927 Merge pull request #2105 from nats-io/interest_delete
Pull based consumers when deleted were not removing messages from an interest retention stream.
2021-04-12 11:41:37 -07:00
Derek Collison
c63f1d78b2 Merge pull request #2104 from nats-io/pbug2
Make sure we do not set last to -1
2021-04-12 11:19:09 -07:00
Derek Collison
f893345b40 Pull based consumers when deleted were not removing messages from an interest based stream.
Fix for #2097.

Signed-off-by: Derek Collison <derek@nats.io>
2021-04-12 11:16:31 -07:00
Derek Collison
bbb03af442 Make sure we do not set last to -1. #2068
Signed-off-by: Derek Collison <derek@nats.io>
2021-04-12 11:01:41 -07:00
Waldemar Quevedo
a7db58c899 Merge pull request #2103 from wallyqs/sigterm-fix
Make TERM exit 1 as pre v2.2 series
2021-04-12 10:54:50 -07:00
Waldemar Quevedo
8daf6e4995 Make SIGTERM exit 1
Before 2.2 series, the TERM signal used to not be handled
by the server, so it would not have been a clean exit.
In 2.2, it was changed to process TERM signal as a clean exit
but this affects the behavior of some tools that were expecting
TERM to be exit 1.

Signed-off-by: Waldemar Quevedo <wally@synadia.com>
2021-04-12 10:17:13 -07:00
Ivan Kozlovic
9d8ea6b64a Merge pull request #2102 from nats-io/fix_leafnode_flapper
Fixed leafnode flapper
2021-04-12 09:59:36 -06:00
Derek Collison
66b0c5c216 Merge pull request #2100 from nats-io/csz
Only adjust cluster size when we have heard from all peers.
2021-04-12 08:52:07 -07:00
Derek Collison
cb55e163a5 Merge pull request #2098 from nats-io/mixedmode
Add mixedmode test back in
2021-04-12 08:48:43 -07:00
Ivan Kozlovic
c369a26c03 Fixed leafnode flapper
Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
2021-04-12 09:31:33 -06:00
Derek Collison
32734960ed Merge pull request #2099 from nats-io/pbug
Partial fix for #2068
2021-04-11 10:46:48 -07:00
Derek Collison
0cee993e3b When checking cluster size we need to make sure we have heard from all peers before making adjustments.
Also check back periodically.

Signed-off-by: Derek Collison <derek@nats.io>
2021-04-10 15:55:51 -07:00
Derek Collison
e0eaf704dc Partial fix for #2068.
This will not protect against the index file being completely removed.

Signed-off-by: Derek Collison <derek@nats.io>
2021-04-10 12:46:31 -07:00
Derek Collison
2bc4bf19a7 Make sure to clean up directories
Signed-off-by: Derek Collison <derek@nats.io>
2021-04-10 10:25:12 -07:00
Derek Collison
833279388b Add mixedmode test back in
Signed-off-by: Derek Collison <derek@nats.io>
2021-04-10 10:10:37 -07:00
Derek Collison
69269c5653 Merge pull request #2095 from nats-io/mixed
Mixed mode improvements.
2021-04-09 16:56:41 -07:00