Commit Graph

6889 Commits

Author SHA1 Message Date
Phil Pennock
2ac72d92bf YAML engineering: quote go version string
We're currently using Go 1.19; we'll switch to 1.20 when the NATS Maintainers
make the call to switch.  Prepare by making sure that 1.20 won't turn into 1.2
instead, by quoting the string to be updated and adding a warning.
2023-02-07 17:32:20 -05:00
Derek Collison
a4bdc11cd7 Merge branch 'main' into dev 2023-02-06 22:19:49 +04:00
Derek Collison
525410127b Merge pull request #3846 from nats-io/consumer-snapshot-logic
Revert consumer snapshot logic
2023-02-06 11:19:29 -07:00
Derek Collison
6a2063f5b3 Revert logic
Signed-off-by: Derek Collison <derek@nats.io>
2023-02-06 22:14:37 +04:00
Derek Collison
3fe85e6cc4 Merge branch 'main' into dev 2023-02-06 21:57:49 +04:00
Derek Collison
c1a6f3ecad Merge pull request #3845 from nats-io/update-filter
[FIXED] Updating consumer filter subject possible panic and deadlock.
2023-02-06 10:55:59 -07:00
Derek Collison
b611e37e95 For updating a consumer filter subject make sure locking ordere correct and that our sublist is present.
Signed-off-by: Derek Collison <derek@nats.io>
2023-02-06 21:34:48 +04:00
Derek Collison
0ffce191cd Bump to 2.9.14-beta
Signed-off-by: Derek Collison <derek@nats.io>
2023-02-04 22:26:19 -08:00
Derek Collison
f7615acb7d Merge branch 'main' into dev 2023-02-04 22:23:50 -08:00
Derek Collison
f4a80838d2 Merge pull request #3844 from nats-io/snapshots-fix
[FIXED] Snapshots Issue
2023-02-04 23:20:08 -07:00
Derek Collison
b22ed47a26 Use fast state in case many interior deletes and small fix for staticcheck
Signed-off-by: Derek Collison <derek@nats.io>
2023-02-04 13:55:41 -08:00
Derek Collison
9c02be2409 Various fixes for snapshots.
Due to bug, in rare circumstances could write an empty snapshot for aplied == 0. This would cause a spinning at the raft layer.

1. Allow Truncate() to also properly do a reset of the store when terms were only mismatch.
2. During testing fixed memstore truncate and also made sure per subject info was also cleaned up.
3. Then added fix to detect a bad snapshot on initialization and remove.
4. Do not allow snapshots for applied == 0.

Signed-off-by: Derek Collison <derek@nats.io>
2023-02-04 13:46:06 -08:00
Waldemar Quevedo
6d94b4181f Merge pull request #3840 from nats-io/bump-2.9.13-beta
Bump 2.9.13-beta
2023-02-02 13:06:19 -06:00
Byron Ruth
a56dcc60c2 Bump 2.9.13-beta
Signed-off-by: Byron Ruth <byron@nats.io>
2023-02-02 14:01:49 -05:00
Waldemar Quevedo
194d9cee38 Merge pull request #3839 from nats-io/release-2-9-12
Release v2.9.12
2023-02-02 12:55:38 -06:00
Byron Ruth
035edeaecb Release v2.9.12
Signed-off-by: Byron Ruth <byron@nats.io>
2023-02-02 13:26:59 -05:00
Derek Collison
2c4ec09cc7 Merge branch 'main' into dev 2023-02-02 11:01:50 -07:00
Derek Collison
5d9a3a10bd Merge pull request #3838 from nats-io/jarema/fix-consumers-after-purge
Fix current consumers not getting messages after purge
2023-02-02 07:48:00 -08:00
Tomasz Pietrek
46af979871 Fix current consumers not getting messages after purge
Until now, purge updated all consumers sequences
even if purge subject was only a subset of given consumer filter.
Because of that, even messages from not purged subjects were not fetched
or properly accounted for existing consumers.

Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
2023-02-02 16:27:32 +01:00
Derek Collison
4744ff3478 Bump to 2.9.12-RC.3
Signed-off-by: Derek Collison <derek@nats.io>
2023-02-01 22:46:25 -07:00
Derek Collison
13e7908c5d Bump to 2.10.0-beta.15
Signed-off-by: Derek Collison <derek@nats.io>
2023-02-01 22:45:38 -07:00
Derek Collison
fad24fb604 Merge branch 'main' into dev 2023-02-01 22:44:38 -07:00
Derek Collison
73d389e41c Merge pull request #3837 from nats-io/snapshot-fix
[FIXED] Do not let !NeedSnapshot() avoid snapshots and compaction.
2023-02-01 21:44:10 -08:00
Derek Collison
e9a983c802 Do not let !NeedSnapshot() avoid snapshots and compaction.
Signed-off-by: Derek Collison <derek@nats.io>
2023-02-01 22:05:25 -07:00
Derek Collison
76e93fc955 Merge branch 'main' into dev 2023-01-31 15:26:02 -07:00
Waldemar Quevedo
d40c4c6fb3 Merge pull request #3835 from nats-io/go-1.19.5
Bump to Go 1.19.5
2023-01-31 15:30:24 -06:00
Byron Ruth
163743ab3f Bump to Go 1.19.5
Signed-off-by: Byron Ruth <byron@nats.io>
2023-01-31 15:43:16 -05:00
Derek Collison
42cdc4e39d Merge branch 'main' into dev 2023-01-31 10:10:29 -08:00
Derek Collison
cb743aef87 Merge pull request #3834 from nats-io/pkg-updates
[UPDATED] Package updates
2023-01-31 10:05:00 -08:00
Derek Collison
390fd02918 Updates to tests for updated Go client changes
Signed-off-by: Derek Collison <derek@nats.io>
2023-01-31 09:47:36 -08:00
Derek Collison
12a49859e9 Update pkg dependencies
Signed-off-by: Derek Collison <derek@nats.io>
2023-01-31 09:33:01 -08:00
Derek Collison
7607b17844 Fix for test
Signed-off-by: Derek Collison <derek@nats.io>
2023-01-30 20:14:39 -08:00
Derek Collison
2d6b316efd Merge branch 'main' into dev 2023-01-30 20:07:26 -08:00
Derek Collison
1252653c16 Merge pull request #3829 from nats-io/jarema/fix-message-after-update
Fix Consumer not getting messages after filter update
2023-01-30 19:59:32 -08:00
Derek Collison
d9aa69c332 Bump to 2.9.12-RC.2
Signed-off-by: Derek Collison <derek@nats.io>
2023-01-30 19:56:53 -08:00
Derek Collison
aaacca8549 Merge branch 'main' into dev 2023-01-30 19:54:37 -08:00
Derek Collison
e0798d26eb Merge pull request #3831 from nats-io/snapshots
Minor fixes and optimizations for snapshots.
2023-01-30 19:53:22 -08:00
Derek Collison
740ec2f85e Merge pull request #3832 from nats-io/deadlock-fix
[FIXED] Deadlock on dataloss when holding mb lock.
2023-01-30 19:49:51 -08:00
Derek Collison
598e27243f Fix possible deadlock on dataloss
Signed-off-by: Derek Collison <derek@nats.io>
2023-01-30 19:10:19 -08:00
Derek Collison
6058056e3b Minor fixes and optimizations for snapshots.
We were snappshotting more then needed, so double check that we should be doing this at the stream and consumer level.
At the raft level, we should have always been compacting the WAL to last+1, so made that consistent. Also fixed bug that would not skip last if more items behind the snapshot.

Signed-off-by: Derek Collison <derek@nats.io>
2023-01-30 17:54:18 -08:00
Derek Collison
e7d7313640 Merge pull request #3830 from nats-io/shutdown-fix
Fix for isGroupLeaderless when JS not available (due to shutdown)
2023-01-30 17:18:33 -08:00
Waldemar Quevedo
13372508e2 Fix for isGroupLeaderless when JS not available (due to shutdown)
Signed-off-by: Waldemar Quevedo <wally@nats.io>
2023-01-30 15:29:42 -08:00
Tomasz Pietrek
836848ca64 Fix Consumer not getting messages after filter update
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
2023-01-30 20:47:17 +01:00
Derek Collison
fd371781b2 Merge pull request #3828 from nats-io/kv-opt
A few small optimizations
2023-01-30 08:13:57 -08:00
Derek Collison
52a78c0352 Small optimizations.
1. Only snapshot with minSnap time window like consumers and meta. Make it consistent for all to 5s.
2. Only snapshot at the end of processing all entries pending vs inside the loop.
3. Use fast state when calculating sync request, do not need deleted details there.

Signed-off-by: Derek Collison <derek@nats.io>
2023-01-29 10:58:00 -08:00
Derek Collison
a505c88d65 Merge pull request #3827 from nats-io/jnm/streamsubjectransformimprove1
Stream subject transform improvements
2023-01-29 10:34:10 -08:00
Jean-Noël Moyne
3518c9460a Small formatting improvements 2023-01-28 12:59:36 -08:00
Derek Collison
e1a2da8d85 Small optimizations
Signed-off-by: Derek Collison <derek@nats.io>
2023-01-28 11:45:47 -08:00
Derek Collison
bf49f23bb1 Only hold on to so many pending in memory, will fetch from WAL
Signed-off-by: Derek Collison <derek@nats.io>
2023-01-28 11:34:55 -08:00
Jean-Noël Moyne
ccc492bdce Improve checking that subject filters and destination transforms are valid subjects.
Improve error messages when bad filters/transforms are encountered.
Cover all cases of updating an existing stream's subject transform or sources
2023-01-27 17:54:37 -08:00