gogrlx/nats-server
1
0
Fork 0
mirror of https://github.com/gogrlx/nats-server.git synced 2026-04-02 03:38:42 -07:00
Code Issues Packages Projects Releases Wiki Activity
7,012 Commits 30 Branches 48 Tags
313dd424a327e7b46f2e674b24c8f515c989c703
Commit Graph

7012 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Derek Collison
313dd424a3 Optimize to not allocate converting strings to []byte 
Signed-off-by: Derek Collison <derek@nats.io>
 2023-04-08 20:46:05 -07:00
Derek Collison
ad08ee3898 Remove unused function 
Signed-off-by: Derek Collison <derek@nats.io>
 2023-04-08 20:28:44 -07:00
Derek Collison
722a48d726 Don't require lock for check no echo status 
Signed-off-by: Derek Collison <derek@nats.io>
 2023-04-08 20:05:33 -07:00
Derek Collison
c6b2a97ef4 Use entry pool 
Signed-off-by: Derek Collison <derek@nats.io>
 2023-04-08 19:58:43 -07:00
Derek Collison
fa73b572e6 Optimize with Pool and avoid allocations on []byte cast of strings 
Signed-off-by: Derek Collison <derek@nats.io>
 2023-04-08 19:58:09 -07:00
Derek Collison
3b9cf1e381 Needed to do more in separate go routine to avoid deadlock 
Signed-off-by: Derek Collison <derek@nats.io>
 2023-04-08 18:43:58 -07:00
Derek Collison
b78ec39b1f Fix data race and simplify logic 
Signed-off-by: Derek Collison <derek@nats.io>
 2023-04-08 15:04:30 -07:00
Derek Collison
35bb7c1737 Pool CommittedEntries as well with a ReturnToPool() that will also recycle the Entry. Needs to integrate with upper layers 
Signed-off-by: Derek Collison <derek@nats.io>
 2023-04-08 11:34:10 -07:00
Derek Collison
ffc49b8f86 Fix flapping test and data race in test 
Signed-off-by: Derek Collison <derek@nats.io>
 2023-04-08 08:13:31 -07:00
Derek Collison
3be25fdedb Do not put an appendEntryResponse back in the pool if catching up until complete 
Signed-off-by: Derek Collison <derek@nats.io>
 2023-04-07 10:30:06 -07:00
Derek Collison
4edb08280f Use trick to intern strings with GC for subjString 
Signed-off-by: Derek Collison <derek@nats.io>
 2023-04-07 09:14:57 -07:00
Derek Collison
2ff6f18ccd Use sync.Map for peers vs internal storage for appendEntryResponses 
Signed-off-by: Derek Collison <derek@nats.io>
 2023-04-07 08:16:42 -07:00
Derek Collison
1caa56a34f Use pools for appendEntries 
Signed-off-by: Derek Collison <derek@nats.io>
 2023-04-07 07:38:19 -07:00
Derek Collison
83f08999a7 Fix data race 
Signed-off-by: Derek Collison <derek@nats.io>
 2023-04-07 07:30:03 -07:00
Derek Collison
d02d59534f Fix data race 
Signed-off-by: Derek Collison <derek@nats.io>
 2023-04-07 07:18:30 -07:00
Derek Collison
bb2da435c2 Only cast and copy if really needed 
Signed-off-by: Derek Collison <derek@nats.io>
 2023-04-07 06:53:57 -07:00
Derek Collison
3afdb99f75 Use pools for appendEntryResponses. Also use interior space for peer name from the wire 
Signed-off-by: Derek Collison <derek@nats.io>
 2023-04-07 06:43:51 -07:00
Derek Collison
84c0d48815 [FIXED] Make sure on reverse match to compensate for wider target subjects. (#4032) 
If we have a wider subject, meaning more tokens, but our subs end with a
wildcard token make sure that matches properly.

Signed-off-by: Derek Collison <derek@nats.io>
 2023-04-06 16:03:52 -07:00
Derek Collison
dbde8aba36 Make sure on reverse match to compensate for wider target subjects 
Signed-off-by: Derek Collison <derek@nats.io>
 2023-04-06 14:27:04 -07:00
Derek Collison
02122a233d [IMPROVED] Finer grained locking for /healthz with large number of JetStream assets. (#4031) 
For checking the health of jetstream, do not hold the lock as we
traverse the streams and consumers.

 Signed-off-by: Derek Collison <derek@nats.io>
 2023-04-06 12:37:06 -07:00
Derek Collison
c16915bff4 For checking the health of jetstream, do not hold the lock as we traverse the streams and consumers. 
Signed-off-by: Derek Collison <derek@nats.io>
 2023-04-06 11:56:55 -07:00
Derek Collison
33451e5d56 Fix for API data race. (#4030) 
Signed-off-by: Derek Collison <derek@nats.io>
 2023-04-06 10:45:29 -07:00
Derek Collison
f02f379468 Move stepdowns of streams and consumers to not be inline. (#4029) 
Signed-off-by: Derek Collison <derek@nats.io>
 2023-04-06 10:45:16 -07:00
Derek Collison
a60f623842 Fix flapping test since claims not processed inline now 
Signed-off-by: Derek Collison <derek@nats.io>
 2023-04-06 10:39:30 -07:00
Derek Collison
dee5229f9b Fix data race 
Signed-off-by: Derek Collison <derek@nats.io>
 2023-04-06 10:37:31 -07:00
Derek Collison
0d2269b1e9 Move stepdowns of streams and consumers to not be inline 
Signed-off-by: Derek Collison <derek@nats.io>
 2023-04-06 10:27:36 -07:00
Derek Collison
7547093b24 _EMPTY_ 
Signed-off-by: Derek Collison <derek@nats.io>
 2023-04-06 08:38:30 -07:00
Derek Collison
1e80ea68b3 [IMPROVED] Optimize non-inline direct gets to not use simple go routines. (#4028) 
This was causing regression in certain KV performance tests.

Signed-off-by: Derek Collison <derek@nats.io>
 2023-04-06 08:35:37 -07:00
Derek Collison
2da50512e2 Optimize non-inline direct gets to not use simple go routines 
Signed-off-by: Derek Collison <derek@nats.io>
 2023-04-06 07:50:57 -07:00
Derek Collison
7b82384fd7 ADDED hard_delete option on resolver configuration (#3783) 
- [x] Link to issue, e.g. `Resolves #NNN`
 - [ ] Documentation added (if applicable)
 - [ ] Tests added
- [x] Branch rebased on top of current main (`git pull --rebase origin
main`)
- [x] Changes squashed to a single commit (described
[here](http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html))
 - [x] Build is green in Travis CI
- [x] You have certified that the contribution is your original work and
that you license the work to the project under the [Apache 2
license](https://github.com/nats-io/nats-server/blob/main/LICENSE)

Resolves #3782

### Changes proposed in this pull request:

- Add hard_delete option in the resolver config and use it to set the
deleteType in NewDirAccResolver

/cc @nats-io/core
 2023-04-06 07:04:03 -07:00
Derek Collison
a5326c97ef [IMPROVED] Head of line improvements (#4027) 
Signed-off-by: Derek Collison <derek@nats.io>
 2023-04-05 22:03:43 -07:00
Derek Collison
e76b0b9b96 Move check for out of resources which would want a read lock out of inline processing 
Signed-off-by: Derek Collison <derek@nats.io>
 2023-04-05 20:28:19 -07:00
Derek Collison
b6ebf0fe43 RWMutex does not help here and could hurt 
Signed-off-by: Derek Collison <derek@nats.io>
 2023-04-05 20:26:45 -07:00
Derek Collison
81541361dc Alternative fix for issue 4014, where we always send pings on ROUTER connections (#4016) 
Alternative fix for issue
https://github.com/nats-io/nats-server/issues/4014: where we always send
pings for ROUTER, GATEWAY and LEAF spoke connections.

This is my own original work that I license to the project

[ x] Link to issue, e.g. Resolves #NNN
 Documentation added (if applicable)
 Tests added
[ x] Branch rebased on top of current main (git pull --rebase origin
main)
[ x] Changes squashed to a single commit (described
[here](http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html))
[x] Build is green in Travis CI
[ x] You have certified that the contribution is your original work and
that you license the work to the project under the [Apache 2
license](https://github.com/nats-io/nats-server/blob/main/LICENSE)
Resolves #

Changes proposed in this pull request:
- in processPingTimer, add explicit test for ROUTER connection, and only
hold off sending ping based on receive ping
 2023-04-05 20:16:22 -07:00
Sandy Kellagher
5ae83b7983 Alternative fix for issue 4014, where we always send pings on ROUTER connections, updating c.lastIn timestamp on receiving client data or ping 2023-04-05 13:03:46 +01:00
Julien Viard de Galbert
1b1610f2da Adding hard_delete option on resolver configuration 
Signed-off-by: Julien Viard de Galbert <jviarddegalbert@scaleway.com>
 2023-04-05 10:05:48 +02:00
Derek Collison
d14968cb4f Bump to 2.9.16-RC.6 
Signed-off-by: Derek Collison <derek@nats.io>
 2023-04-04 15:15:24 -07:00
Derek Collison
2167f39ccd [IMPROVED] Do not block routes, leafnodes or gateways on received internal system msgs. (#4026) 
To increase system stability in large NATS systems we do not want to
process inbound system messages that are destined to be processed by the
server itself to be processed inline on the inbound connection.

Signed-off-by: Derek Collison <derek@nats.io>
 2023-04-04 15:13:02 -07:00
Derek Collison
3036bb8bc5 Fix for test 
Signed-off-by: Derek Collison <derek@nats.io>
 2023-04-04 14:43:46 -07:00
Derek Collison
208f4625df Possibly de-race sysRequest (#4017) 
This may fix a race condition in `sysRequest` where multiple inbox
responses could try to mutate the same input object, so instead we'll
let it instantiate its own, although it isn't clear to me yet why that
would happen in the first place.

Signed-off-by: Neil Twigg <neil@nats.io>
 2023-04-04 14:40:11 -07:00
Derek Collison
b14a400df6 Fix for debugSubscribers and claims test 
Signed-off-by: Derek Collison <derek@nats.io>
 2023-04-04 14:36:16 -07:00
Derek Collison
3551c7b2bf Convert over zReq to not have to call msgparts 
Signed-off-by: Derek Collison <derek@nats.io>
 2023-04-04 14:23:50 -07:00
Derek Collison
c323ec3086 Non-inline system callbacks need hdr and msg already split due to client context to split 
Signed-off-by: Derek Collison <derek@nats.io>
 2023-04-04 14:15:30 -07:00
Derek Collison
9f95e993e2 Do not inline inbound system messages to avoid blocking routes, gateways etc. 
Signed-off-by: Derek Collison <derek@nats.io>
 2023-04-04 13:53:21 -07:00
Neil Twigg
03a5a4deaf Possibly de-race sysRequest 
Signed-off-by: Neil Twigg <neil@nats.io>
 2023-04-04 10:30:59 +01:00
Derek Collison
d5a525bde0 Bump to 2.9.16-RC.5 
Signed-off-by: Derek Collison <derek@nats.io>
 2023-04-03 21:23:35 -07:00
Derek Collison
34922df706 [IMPROVED] Make sure to never process next message requests inline. (#4022) 
Signed-off-by: Derek Collison <derek@nats.io>
 2023-04-03 21:22:31 -07:00
Derek Collison
ebe4f8957f Spelling based on review feedback 
Signed-off-by: Derek Collison <derek@nats.io>
 2023-04-03 21:08:59 -07:00
Derek Collison
dcbefd5cc4 We can receive these on push consumers, so error if we do 
Signed-off-by: Derek Collison <derek@nats.io>
 2023-04-03 21:07:08 -07:00
Derek Collison
07b34f707f Make sure to never process next message requests inline 
Signed-off-by: Derek Collison <derek@nats.io>
 2023-04-03 20:50:01 -07:00