Commit Graph

6892 Commits

Author SHA1 Message Date
Derek Collison
57daedafa8 Merge pull request #3986 from nats-io/neil/shutdownraftgroups
Shut down RAFT groups when disabling JetStream
2023-03-23 11:09:35 -07:00
Neil Twigg
8d5519356e Shut down RAFT groups when disabling JetStream
Signed-off-by: Neil Twigg <neil@nats.io>
2023-03-23 16:54:01 +00:00
Derek Collison
61556d90bd Merge pull request #3985 from nats-io/oor-raft
Only process out of resources condition from raft layer if err matches explicitly.
2023-03-23 08:39:15 -07:00
Derek Collison
ec89823e1c Only process out of resources condition from raft layer if err matches condition
Signed-off-by: Derek Collison <derek@nats.io>
2023-03-23 08:13:22 -07:00
Derek Collison
cec1e15c4b Merge pull request #3983 from nats-io/pre-acks-test
Test for preAcks
2023-03-21 13:16:09 -07:00
Derek Collison
9ccd7abdf8 Test for preAcks
Signed-off-by: Derek Collison <derek@nats.io>
2023-03-21 12:08:24 -07:00
Derek Collison
2551e6f6a8 Merge pull request #3981 from nats-io/f3-2
Improved publisher performance under some instances of asymmetric network latency clusters.
2023-03-20 21:32:30 -07:00
Derek Collison
ed9de4b0a1 Improved publisher performance under some instances of asymmetric network latency clusters on interest based streams.
Under asymmetric network latency based clusters, if a node in an R3 was replicating a consumer and the parent stream, but was the leader of neither, but the path from the stream leader was faster then the consumer leader a replicated ack could arrive before the message itself.

In this case we used to forward a delete message request to the stream leader which would then replicate that to all stream replicas, causing more work which could lead to increased publisher times on clients connected to the slow node.

Signed-off-by: Derek Collison <derek@nats.io>
2023-03-20 20:53:45 -07:00
Derek Collison
3e0ce6e639 Merge pull request #3980 from nats-io/f3
[FIXED] Fixed an issue with consumer states growing and causing instability.
2023-03-19 11:55:26 -07:00
Derek Collison
0c1301ec14 Fix for data race
Signed-off-by: Derek Collison <derek@nats.io>
2023-03-19 10:52:52 -07:00
Derek Collison
5a16f98427 Fixed an off by one bug that under certain circumstances could cause large consumer replica states.
This could lead to instability in the system.

The bug would manifest in replicated consumers when certain messages could be acked out of order, and, the pending list would never go to zero.

Signed-off-by: Derek Collison <derek@nats.io>
2023-03-19 10:41:59 -07:00
Derek Collison
3e8e0ea44a Merge pull request #3979 from nats-io/cores-snap
Remove snapshotting of cores and maxprocs.
2023-03-18 08:18:24 -07:00
Derek Collison
027f2e42c8 Remove snapshot of cores and maxprocs
Signed-off-by: Derek Collison <derek@nats.io>
2023-03-17 15:09:50 -07:00
Derek Collison
f0e1585490 Fix flapping test
Signed-off-by: Derek Collison <derek@nats.io>
2023-03-17 13:14:43 -07:00
Neil
1cfb1b0c3c Merge pull request #3978 from nats-io/neil/encfix
Don't recycle buffer more than once
2023-03-17 09:42:19 +00:00
Neil Twigg
4647e14b3e Don't recycle buffer more than once 2023-03-17 09:25:17 +00:00
Neil
5c437a233a Merge pull request #3975 from nats-io/neil/encbuffer
Use pooled buffer for flushing encrypted message blocks
2023-03-16 18:09:51 +00:00
Neil Twigg
9f99efad03 Use pooled buffer for flushing encrypted message blocks 2023-03-16 17:43:09 +00:00
R.I.Pienaar
33c0f8e613 Merge pull request #3972 from ripienaar/nightly_rc_docker.4
move dev nightly to same shared action
2023-03-16 12:25:23 +01:00
R.I.Pienaar
447a174065 move dev nightly to same shared action
Signed-off-by: R.I.Pienaar <rip@devco.net>
2023-03-16 11:23:41 +01:00
Derek Collison
c4075ddac4 Merge pull request #3970 from nats-io/ackfloor-fseq
Remove msgs from interest based stream on consumer snapshot.
2023-03-15 20:25:33 -07:00
Derek Collison
5bb6f167b9 Make sure to cleanup messages on a follower consumer for an interest based stream when the consumer leader sends a state snapshot.
Signed-off-by: Derek Collison <derek@nats.io>
2023-03-15 20:11:16 -07:00
Derek Collison
d1048ac2c9 Merge pull request #3968 from nats-io/raft-warn-on-closed
Don't warn if error is node closed.
2023-03-15 18:25:50 -07:00
Derek Collison
8dbfbbe577 Fix test
Signed-off-by: Derek Collison <derek@nats.io>
2023-03-15 17:23:51 -07:00
Derek Collison
531fadd3e2 Don't warn if error is node closed.
Signed-off-by: Derek Collison <derek@nats.io>
2023-03-15 16:45:33 -07:00
R.I.Pienaar
032b1f1fee Merge pull request #3967 from ripienaar/nightly_rc_docker.3
resolve access to secrets and a few other issues
2023-03-15 13:59:22 +01:00
R.I.Pienaar
2e362fee40 resolve access to secrets and a few other issues
Signed-off-by: R.I.Pienaar <rip@devco.net>
2023-03-15 13:41:30 +01:00
R.I.Pienaar
7f60363d8a Merge pull request #3966 from ripienaar/nightly_rc_docker.2
fix uses for embedded action in nightly build
2023-03-15 12:03:46 +01:00
R.I.Pienaar
54da8b4f8a fix uses for embedded action in nightly build
The uses option requires a path that start with . for local files

Signed-off-by: R.I.Pienaar <rip@devco.net>
2023-03-15 11:44:56 +01:00
Neil
c0784bc363 Merge pull request #3952 from nats-io/neil/fssdirty
Only mark fss dirty if a change is made
2023-03-15 09:25:11 +00:00
Waldemar Quevedo
c1373d6666 Merge pull request #3964 from nats-io/ocsp-leaf-fixes
Fix leaf client connection failing in OCSP setups
2023-03-14 17:30:25 -07:00
Waldemar Quevedo
da7a8b63bc Reword ocsp routes/gateways terminology to 'peers' instead
Add test for verify_and_map usage with ocsp

Signed-off-by: Waldemar Quevedo <wally@nats.io>
2023-03-14 17:01:42 -07:00
R.I.Pienaar
84de2a3b72 Merge pull request #3963 from nats-io/nightly_rc_docker.2
fix path to actions file
2023-03-14 22:43:52 +01:00
Waldemar Quevedo
f8914788f5 Fix leaf client connection failing in ocsp setup
Signed-off-by: Waldemar Quevedo <wally@nats.io>
2023-03-14 14:07:18 -07:00
R.I.Pienaar
d3c8fddef3 fix path to actions file
Signed-off-by: R.I.Pienaar <rip@devco.net>
2023-03-14 21:43:17 +01:00
R.I.Pienaar
dd9851f87d Merge pull request #3962 from ripienaar/nightly_rc_docker.1
checkout code before calling action
2023-03-14 20:40:30 +01:00
R.I.Pienaar
a8f33d594c checkout code before calling action
This ensures that the action can be found.

Signed-off-by: R.I.Pienaar <rip@devco.net>
2023-03-14 19:47:20 +01:00
R.I.Pienaar
82e32d9c5e Merge pull request #3961 from ripienaar/nightly_rc_docker
adds a nightly build action and build nightly rc from main
2023-03-14 19:42:02 +01:00
R.I.Pienaar
204c53dcb2 adds a nightly build action and build nightly rc from main
Signed-off-by: R.I.Pienaar <rip@devco.net>
2023-03-14 19:20:18 +01:00
Derek Collison
3ecf55bcf3 Merge pull request #3960 from nats-io/fix-3953
[FIXED] Scaling up workqueue stream does not remove ack'd messages.
2023-03-14 06:52:11 -07:00
Derek Collison
5a1878b015 Fix for workqueue stream scaling up and not removing acked messages.
Make sure when scaling up streams that are workqueue or interest policy that consumers scale as well.

Signed-off-by: Derek Collison <derek@nats.io>
2023-03-13 17:13:49 -07:00
Neil
07bc964d51 Merge pull request #3956 from nats-io/neil/subjstring
Don't use string builder in `subjString` (it is slow)
2023-03-13 12:52:40 +00:00
Neil Twigg
7105df5afc Don't use string builder in subjString (it is slow) 2023-03-13 11:56:05 +00:00
Neil Twigg
1ead6df6f1 Only mark fss dirty if a change is made 2023-03-10 12:53:29 +00:00
Derek Collison
a181e90c39 Merge pull request #3945 from nats-io/orphan-deadlock
[FIXED] Do not hold jetstream lock cleaning up orphans, could deadlock.
2023-03-08 02:30:11 -08:00
Derek Collison
062dec7f5e Added in error warning if stream or consumer delete fails.
Signed-off-by: Derek Collison <derek@nats.io>
2023-03-07 19:26:29 -05:00
Derek Collison
e0cbe503ed Do not hold jetstream lock cleaning up orphans.
Could optionally deadlock.

Signed-off-by: Derek Collison <derek@nats.io>
2023-03-07 06:42:53 -05:00
Tomasz Pietrek
c1af58507b Merge pull request #3942 from nats-io/jarema/fix-pull-consumer-timeout
Fix Pull Consumer not sending request timeout
2023-03-03 16:52:20 +01:00
Tomasz Pietrek
df282a221c Fix Pull Consumer not sending request timeout
Server did check for timeouts in `processWaiting`,
but that needs to be also checked in `nextWaiting` in case of
tight timings, as `nextWaiting` can remove Pull Request based on
timeouts too.

Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
2023-03-03 14:49:04 +01:00
Derek Collison
6db06d117b Merge pull request #3939 from nats-io/fix-jsz-mon-test
Fix flaky test TestMonitorJsz/raftgroups
2023-03-02 12:23:38 -08:00