Commit Graph

6477 Commits

Author SHA1 Message Date
Ivan Kozlovic
ab4470ccdc [FIXED] JetStream: possible panic on some rare cases
Very difficult to reproduce. Had to run TestJetStreamSuperClusterMoveCancel
in covermode=atomic on a slow machine to hit the condition where
the monitorConsumer go routine is started by RAFT node is nil,
which caused the warning message to produce the panic (since n is nil)

Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
2022-11-02 10:02:09 -06:00
Ivan Kozlovic
2321eafb0c Bump version to 2.9.6-beta as per release process
Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
2022-11-01 16:23:50 -06:00
Ivan Kozlovic
ceebf53cf6 Merge pull request #3597 from nats-io/release_2_9_5
Release v2.9.5
2022-11-01 15:33:02 -06:00
Ivan Kozlovic
c16f60add5 Release v2.9.5
Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
2022-11-01 15:15:06 -06:00
Ivan Kozlovic
32041d98d7 Merge pull request #3596 from nats-io/js_process_snap
[FIXED] JetStream: processing of snapshot with expired messages
2022-11-01 13:27:29 -06:00
Ivan Kozlovic
55e651c118 [FIXED] JetStream: processing of snapshot with expired messages
The issue that a "first sequence mismatch" during processing of
a snapshot was causing the state to be reset and caused a lot
of catchup from the follower. An attempt to fix that in PR #3567
caused an issue that was addressed in PR #3589. However, this was
then causing the follower to sometime never able to catchup or
took a very long time.
This PR - we believe - addresses the original and subsequent issues.

Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
2022-11-01 12:58:45 -06:00
Derek Collison
56bd22f536 Merge pull request #3595 from nats-io/max-msgs-per-update
[FIXED] Honor MaxMsgsPerSubject during a stream config update.
2022-11-01 09:41:55 -07:00
Derek Collison
1fa5e73177 Honor MaxMsgsPerSubject when a stream config is updated, including enforcing a lower limit.
Signed-off-by: Derek Collison <derek@nats.io>
2022-10-31 17:25:20 -07:00
Ivan Kozlovic
4f252d3ef8 Merge pull request #3592 from nats-io/fix_flapper
Fixing a flapper
2022-10-28 14:34:38 -06:00
Ivan Kozlovic
fe588dc9ea Fixing a flapper
Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
2022-10-28 13:45:58 -06:00
Ivan Kozlovic
a0719ec7a7 Merge pull request #3591 from aopetrov86/less-optimistic-cache-hit-rate
[FIXED] Sublist's cache hit rate would be wrong in presence of multiple accounts
2022-10-28 09:29:42 -06:00
Александр Петров
8eb430bfff add test 2022-10-28 20:16:40 +05:00
Александр Петров
19f63bee65 less optimistic cache hit rate 2022-10-28 11:36:46 +05:00
Ivan Kozlovic
3f0f3d7416 Bump version to 2.9.5-beta.1
Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
2022-10-27 19:15:01 -06:00
Derek Collison
d6b4bdee69 Merge pull request #3589 from nats-io/sreq-nil
[FIXED] Move code that references sreq past the check for nil
2022-10-27 18:10:41 -07:00
Derek Collison
121bf6ebb5 Move to past check for nil
Signed-off-by: Derek Collison <derek@nats.io>
2022-10-27 17:30:07 -07:00
Ivan Kozlovic
3a5f465115 Bump to 2.9.5-beta as per release process
Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
2022-10-27 17:15:00 -06:00
Ivan Kozlovic
0b9529469e Merge pull request #3588 from nats-io/release_2_9_4
Release v2.9.4
2022-10-27 16:35:51 -06:00
Ivan Kozlovic
f101e815fe Release v2.9.4
Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
2022-10-27 16:10:39 -06:00
Derek Collison
bd1df4bfd5 Bump to 2.9.4-RC.3
Signed-off-by: Derek Collison <derek@nats.io>
2022-10-27 13:21:08 -07:00
Derek Collison
95d91b2869 Merge pull request #3585 from nats-io/leaf-perms
[FIXED] Existing subs would be sent to leafnodes even though they violated permissions.
2022-10-27 15:19:48 -05:00
Ivan Kozlovic
2e2596916a Merge pull request #3587 from nats-io/add_pending_msgs_bytes_on_shutdown
Add the pending msgs/bytes on 409 Shutdown
2022-10-27 14:16:41 -06:00
Derek Collison
9bbf0aaaf0 Merge pull request #3586 from nats-io/client-update-2
Update Go client to release 1.19.0
2022-10-27 15:16:11 -05:00
Derek Collison
a746b578e7 Update Go client to release 1.19.0
Signed-off-by: Derek Collison <derek@nats.io>
2022-10-27 13:03:54 -07:00
Ivan Kozlovic
abcfe2e7ac Add the pending msgs/bytes on 409 Shutdown
This is related to PR #3572 and PR #3576

Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
2022-10-27 13:59:21 -06:00
Derek Collison
9c5ae6baef Existing subs would be sent to leafnodes even though pub perms should disallow.
If the LS+ gets through we debug that it was denied, but also fixed it so that does not happen.

Signed-off-by: Derek Collison <derek@nats.io>
2022-10-27 12:31:57 -07:00
Derek Collison
24081ae78e Bump to 2.9.4-RC.2
Signed-off-by: Derek Collison <derek@nats.io>
2022-10-27 09:19:22 -07:00
Derek Collison
c4847194ea Merge pull request #3584 from nats-io/update_client
Updated Go client
2022-10-27 11:18:04 -05:00
Derek Collison
d89992990b Merge pull request #3582 from nats-io/fix
Make sure to check for ss == nil
2022-10-27 11:07:11 -05:00
Ivan Kozlovic
6a2b59bf91 Merge pull request #3583 from nats-io/fix_3581
[FIXED] `allow_non_tls` is lost after server reload
2022-10-27 10:03:23 -06:00
Derek Collison
1a193fe8a6 Updated Go client
Signed-off-by: Derek Collison <derek@nats.io>
2022-10-27 08:55:43 -07:00
Derek Collison
8f6d55a878 Make sure to check for ss == nil
Signed-off-by: Derek Collison <derek@nats.io>
2022-10-27 08:52:42 -07:00
Ivan Kozlovic
b3e0431959 [FIXED] allow_non_tls is lost after server reload
The server would reset its INFO's TLSRequired to the presence
of a TLS configuration without checking for the allow_non_tls
option.

Resolves #3581

Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
2022-10-27 09:49:44 -06:00
Derek Collison
8cc87c988f Bump to 2.9.4-RC.1
Signed-off-by: Derek Collison <derek@nats.io>
2022-10-26 17:52:28 -07:00
Derek Collison
dd707c5e82 Merge pull request #3579 from nats-io/fs-maxmsgsper-restart
[FIXED] MaxMsgPerSubject recovered on corrupt or missing index file.
2022-10-26 18:12:32 -05:00
Derek Collison
6128b83507 On abnormal server exit, for streams or KV with max msgs per subject set we could recover more than N msgs per subject.
This fix allows for recover of correct state on restart when index files are missing or not current.

Signed-off-by: Derek Collison <derek@nats.io>
2022-10-26 16:00:57 -07:00
Tomasz Pietrek
f0219e1d95 Merge pull request #3572 from nats-io/jarema/add-pending-info-to-request-timeout
Added pending messages/bytes info to request statuses and errors
2022-10-26 21:20:20 +02:00
Tomasz Pietrek
ef764598ee Add pending messages/bytes info to request errors and statuses
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
2022-10-26 20:02:11 +02:00
Derek Collison
77d3f37a8c Merge pull request #3578 from nats-io/high-lag
Added warning for high message lag into a clustered stream.
2022-10-25 19:08:35 -05:00
Derek Collison
2241ad089e Make local error since non-fatal for now.
Signed-off-by: Derek Collison <derek@nats.io>
2022-10-25 16:56:10 -07:00
Derek Collison
aa52c2fecf Added warning for high message lag into a clustered stream.
Signed-off-by: Derek Collison <derek@nats.io>
2022-10-25 16:11:35 -07:00
Derek Collison
db13766f18 Merge pull request #3576 from nats-io/signal-pull-consumers
Removed ephemeral consumer migration.
2022-10-25 17:35:35 -05:00
Derek Collison
09a5ce507e Merge pull request #3577 from nats-io/stop-raft
Make sure to stop raft nodes on all monitor exits.
2022-10-25 17:35:22 -05:00
Derek Collison
f0afa49b9f Make sure to stop raft nodes on all monitor exits.
Signed-off-by: Derek Collison <derek@nats.io>
2022-10-25 14:48:28 -07:00
Derek Collison
ff2cd1d7f9 Fixed test and bug that would override consumer replicas.
Signed-off-by: Derek Collison <derek@nats.io>
2022-10-25 14:35:20 -07:00
Derek Collison
15dc72db50 Removed migration of ephemerals, added proper signaling for pul consumers pending requests.
Signed-off-by: Derek Collison <derek@nats.io>
2022-10-25 14:35:20 -07:00
Ivan Kozlovic
e6239f01c2 Merge pull request #3575 from nats-io/js_update_inactive_threshold
[FIXED] JetStream: InactiveThreshold updates not always working
2022-10-25 12:11:28 -06:00
Ivan Kozlovic
39f31b0dbe [FIXED] JetStream: InactivityThreshold updates not always working
This is based of @neilalexander PR #3558.

It ensures that the timer is reset/canceled on configuration
update (by the leader only).

Fixed also the issue with a super-cluster where the delete timer
would always be reset at every gateway interval check.

Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
2022-10-25 09:54:01 -06:00
Ivan Kozlovic
1d95fba2b4 Merge pull request #3574 from nats-io/js_cons_create_update_gets_response
[FIXED] JetStream: Update of an R1 consumer would not get a response
2022-10-25 09:45:06 -06:00
Ivan Kozlovic
7ca85e0e80 [FIXED] JetStream: Update of an R1 consumer would not get a response
The update was accepted but the server would not respond to the
client/CLI.

Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
2022-10-25 09:04:35 -06:00