gogrlx/nats-server
1
0
Fork 0
mirror of https://github.com/gogrlx/nats-server.git synced 2026-04-02 11:48:43 -07:00
Code Issues Packages Projects Releases Wiki Activity
7,333 Commits 30 Branches 48 Tags
ba517e4bfbba5bc6ca657a9b60a7d429f53b6791
Commit Graph

7333 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Derek Collison
ba517e4bfb [FIXED] Leaking memory on usage of getHash() (#4329) 
If we created lots of hashes, beyond server names, like for consumer or
stream NRG group names etc, these maps would grow and not release
memory. Performance hit is ~300ns per call, and we can use string intern
trick if need be at a future date since it is GC friendly.

Signed-off-by: Derek Collison <derek@nats.io>

Resolves #4289
 2023-07-20 16:04:18 -07:00
Derek Collison
da60f2ab32 [IMPROVED] Don't error to server logs if message was deleted for consumer (#4328) 
Signed-off-by: Derek Collison <derek@nats.io>
 2023-07-20 15:20:11 -07:00
Derek Collison
b68aed90d3 If we created lots of hashes, beyond server names, like for consumer or stream NRG groups etc, the maps would grow and not release memory. 
In the benchmark on my machine, this added ~300ns per call, but I think that is ok for now vs the memory usage.

Signed-off-by: Derek Collison <derek@nats.io>
 2023-07-20 15:11:28 -07:00
Derek Collison
9280a552b8 Don't error to server logs if message deleted 
Signed-off-by: Derek Collison <derek@nats.io>
 2023-07-20 14:07:35 -07:00
Derek Collison
6c9fb6a938 [FIXED] Server reload with highly active accounts with service imports could cause panic or dataloss (#4327) 
When service imports were reloaded on active accounts with lots of
traffic the server could panic or lose data.

Signed-off-by: Derek Collison <derek@nats.io>
 2023-07-20 13:19:17 -07:00
Derek Collison
7477ce8257 When service imports were reloaded on active accounts with lots of traffic the server could panic or lose data. 
Signed-off-by: Derek Collison <derek@nats.io>
 2023-07-20 12:20:50 -07:00
Derek Collison
8e49fcc6df Undo branch build restrictions, quote go version 
Signed-off-by: Derek Collison <derek@nats.io>
 2023-07-20 11:17:19 -07:00
Derek Collison
0347f272c8 Don't require TLS for in-process connection (#4323) 
This should fix a bug where in-process connections expect TLS over the
`net.Pipe` if TLS is configured.

Signed-off-by: Neil Twigg <neil@nats.io>
 2023-07-20 11:01:09 -07:00
Neil Twigg
b7d6b7e7a9 Add unit test to prove connection works 
Signed-off-by: Neil Twigg <neil@nats.io>
 2023-07-20 11:01:32 +01:00
Caleb Lloyd
7993547bee Adjust in-process server info tls_required to tls_available 
Signed-off-by: Caleb Lloyd <caleb@synadia.com>
 2023-07-20 10:44:03 +01:00
Neil Twigg
ed9fafc796 Don't require TLS for in-process connection 
Signed-off-by: Neil Twigg <neil@nats.io>
 2023-07-20 10:43:58 +01:00
Derek Collison
80fb29f9e3 Add test case for concurrent expected last subject sequence (#4319) 
Resolves: #4320
 2023-07-18 12:37:57 -07:00
Derek Collison
244dda809c Fix bug that would race around check for last sequence per subject 
Signed-off-by: Derek Collison <derek@nats.io>
 2023-07-18 11:29:59 -07:00
Derek Collison
360f807cef Moved to end for merge with other branches, minor changes 
Signed-off-by: Derek Collison <derek@nats.io>
 2023-07-18 11:29:26 -07:00
Byron Ruth
e7bf1b3132 Add test case for concurrent expected last subject sequence 
Signed-off-by: Byron Ruth <byron@nats.io>
 2023-07-18 11:10:51 -04:00
Derek Collison
75ad503ddc Limit branch builds to main and dev (#4312) 2023-07-17 10:39:34 -07:00
Byron Ruth
94c1988ed8 Limit branch builds to main and dev 
Signed-off-by: Byron Ruth <byron@nats.io>
 2023-07-15 07:01:24 -04:00
Waldemar Quevedo
c1750b8a54 De-flake a few tests (#4311) 
This should hopefully make a small handful of tests less flakey.

Signed-off-by: Neil Twigg <neil@nats.io>
 2023-07-14 09:57:23 -07:00
Neil Twigg
2527e11304 Increase threshold in TestNoRaceJetStreamSlowFilteredInititalPendingAndFirstMsg 
Signed-off-by: Neil Twigg <neil@nats.io>
 2023-07-14 17:05:26 +01:00
Neil Twigg
6cdb0c7838 Wait for current in TestJetStreamClusterStreamUpdateSyncBug so in-flight state changes aren't lost 
Signed-off-by: Neil Twigg <neil@nats.io>
 2023-07-14 17:03:21 +01:00
Neil Twigg
abb47c9554 Only send one message in TestJetStreamRedeliverCount to prevent out-of-order redeliveries 
Signed-off-by: Neil Twigg <neil@nats.io>
 2023-07-14 16:56:01 +01:00
Neil Twigg
144abc0dd9 Make TestJetStreamAccountImportJSAdvisoriesAsService insensitive to event order 
Signed-off-by: Neil Twigg <neil@nats.io>
 2023-07-14 16:51:51 +01:00
Neil Twigg
b58204cff7 Use checkFor in TestJetStreamMsgHeaders 
Signed-off-by: Neil Twigg <neil@nats.io>
 2023-07-14 16:44:24 +01:00
Neil Twigg
979b265e26 Tweak timing in TestJetStreamClusterDeleteConsumerWhileServerDown 
Signed-off-by: Neil Twigg <neil@nats.io>
 2023-07-14 16:44:15 +01:00
Neil
6e0c0bc61d Remap ports in leaf node tests to hopefully reduce flakes (#4309) 
Multiple tests were using the same port numbers and it seems that the
NATS Servers were not always shutting down quickly enough or the test is
reusing a port that was already assigned ephemerally, resulting in
`listen tcp 127.0.0.1:50554: bind: address already in use` failures.

Signed-off-by: Neil Twigg <neil@nats.io>
 2023-07-14 15:36:16 +01:00
Neil Twigg
81dd129043 Move assigned ports out of ephemeral range 
Signed-off-by: Neil Twigg <neil@nats.io>
 2023-07-14 15:08:17 +01:00
Neil Twigg
586717a3c0 Remap ports in leaf node tests to hopefully reduce flakes 
Multiple tests were using the same port numbers and it seems that the
NATS Servers were not always shutting down quickly enough, resulting
in `listen tcp 127.0.0.1:50554: bind: address already in use` failures.

Signed-off-by: Neil Twigg <neil@nats.io>
 2023-07-14 13:49:15 +01:00
Neil
71db34baf7 Bump v2.9.21-beta (#4306) 2023-07-14 13:48:59 +01:00
Byron Ruth
63864490a5 Bump v2.9.21-beta 
Signed-off-by: Byron Ruth <byron@nats.io>
 2023-07-13 16:04:11 -04:00
Waldemar Quevedo
97dd7cb07a Release v2.9.20 (#4305) 2023-07-13 13:00:38 -07:00
Byron Ruth
b055f675ba Release v2.9.20 2023-07-13 15:29:30 -04:00
Derek Collison
ff10e7befe Bump to Go 1.19.11 (#4304) 2023-07-13 11:03:11 -07:00
Byron Ruth
4e6a09400a Bump to Go 1.19.11 
Signed-off-by: Byron Ruth <byron@nats.io>
 2023-07-13 14:00:38 -04:00
Derek Collison
77189b09c7 [FIXED] JetStream republished messages not being received by MQTT QoS0 subscribers (#4303) 
Only discard messages from MQTT QoS0 from internal JetStream clients if
really a QoS1 JetStream publish, not just a JetStream client.

Signed-off-by: Derek Collison <derek@nats.io>

Resolves #4291
 2023-07-13 07:26:26 -07:00
Derek Collison
1f39d744dd Only discard messages from MQTT QoS0 from internal jetstream clients if really a QoS1 jetstream publish. 
Signed-off-by: Derek Collison <derek@nats.io>
 2023-07-12 16:00:59 -07:00
Derek Collison
0c8552cd34 Evaluate service imports when publishing advisories (#4302) 
This should fix #4275 by allowing advisories to be copied into other
accounts via service imports.

Signed-off-by: Neil Twigg <neil@nats.io>
 2023-07-12 12:24:00 -07:00
Neil Twigg
1434ee7da8 More specific check for service imports vs any internal sub 
Signed-off-by: Neil Twigg <neil@nats.io>
 2023-07-12 19:52:31 +01:00
Neil Twigg
fbbbe28278 Evaluate service imports when publishing advisories 
Signed-off-by: Neil Twigg <neil@nats.io>
 2023-07-12 18:18:57 +01:00
Derek Collison
9cfe8b8f75 [FIXED] Restore of encrypted filestore with no main key could cause dataloss (#4301) 
When restoring a filestore with no key generator but it was encrypted,
fail to restore.

Signed-off-by: Derek Collison <derek@nats.io>
 2023-07-12 08:47:42 -07:00
Piotr Piotrowski
e3b132ae34 Test for gathering JS advisories from multiple accounts on a single account 
Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
 2023-07-12 13:26:18 +01:00
Derek Collison
9e9a9a082b When restoring a filestore with no key generator but it was encrypted, fail to restore. 
Signed-off-by: Derek Collison <derek@nats.io>
 2023-07-11 16:27:50 -07:00
Derek Collison
5390272074 Bump to 2.9.20-beta 
Signed-off-by: Derek Collison <derek@nats.io>
 2023-07-11 14:29:17 -07:00
Derek Collison
97dbd6b28e [FIXED] Duplicate queue subs over leafnodes with hub stream import/export with possible dataloss (#4299) 
When a queue subscriber was updated multiple times over a leafnode
connection we added in more shadow subscriptions which could become
zombies when the connection went away.

In a case where a leafnode server had multiple queue subscribers on the
same queue group, the hub server would add in multiple shadow subs.
These subs would not be properly cleaned up and could lead to stale
connections being associated with them.

Signed-off-by: Derek Collison <derek@nats.io>
 2023-07-11 06:52:26 -07:00
Derek Collison
353d543c16 When a queue subscriber was updated multiple times over a leafnode connection we added in more shadow subscriptions which could become zombies when the connection went away. 
In a case where a leafnode server had multiple queue subscribers on the same queue group, the hub server would add in multiple shadow subs. These subs would not be properly cleaned up and could lead to stale connections being associated with them.

Signed-off-by: Derek Collison <derek@nats.io>
 2023-07-10 21:03:47 -07:00
Derek Collison
eb2aa352ec Updated Leafnode Test (#4283) 
Signed-off-by: Derek Collison <derek@nats.io>
 2023-06-30 11:06:11 -07:00
Derek Collison
b207984a84 Made cloud clusters 5 nodes each 
Signed-off-by: Derek Collison <derek@nats.io>
 2023-06-30 10:12:39 -07:00
Neil
57015472a9 Add TestRouteNoLeakOnSlowConsumer and TestRouteNoLeakOnAuthTimeout (#4153) 
These tests are to help verify that routes aren't leaking when they go
down for write deadlines or auth failures.

Signed-off-by: Neil Twigg <neil@nats.io>
 2023-06-30 15:34:07 +01:00
Neil Twigg
0d1c666071 Add TestRouteNoLeakOnSlowConsumer and TestRouteNoLeakOnAuthTimeout 
Signed-off-by: Neil Twigg <neil@nats.io>
 2023-06-30 13:11:42 +01:00
Derek Collison
e31bf5c66d Added reverse flow to the mc leafnode test 
Signed-off-by: Derek Collison <derek@nats.io>
 2023-06-29 16:10:31 -07:00
Derek Collison
503de4593d [FIXED] Do not health check streams that are actively being restored. (#4277) 
Could leave them in a bad state.

Signed-off-by: Derek Collison <derek@nats.io>

Resolves #4270
 2023-06-28 17:48:09 -07:00