Commit Graph

3397 Commits

Author SHA1 Message Date
Alberto Ricart
cf8a44da4e added comments
[ci skip]
2020-11-24 10:58:22 -06:00
Alberto Ricart
3c0cc64877 fixed testing of the user issuer against the account id (Name) - was set to Issuer instead
added some tests.

FIX #1740
2020-11-23 17:38:34 -06:00
Derek Collison
c0bc788c6d Merge pull request #1735 from nats-io/ehdrs
Stream publish changes
2020-11-23 09:44:37 -08:00
Derek Collison
18108be374 Merge pull request #1731 from nats-io/cycle
[FIXED] Detect service import cycles.
2020-11-23 09:43:51 -08:00
Derek Collison
2e7b47f692 Merge pull request #1733 from nats-io/jsimport
Allow complete $JS.API to be imported from another account.
2020-11-23 07:35:24 -08:00
Derek Collison
0279e00b00 Fix for flapper
Signed-off-by: Derek Collison <derek@nats.io>
2020-11-23 07:34:24 -08:00
Derek Collison
39e96984ac Force a copy of the PubAck normal response
Signed-off-by: Derek Collison <derek@nats.io>
2020-11-23 07:10:09 -08:00
Phil Pennock
7c1f50d920 Unbreak FreeBSD compilation (syscall.Statfs_t) (#1734)
The types of fields in syscall.Statfs_t varies between platforms.
fs.Bavail is uint64 on Linux and int64 on FreeBSD.  This is the opposite way
around to fs.Bsize.

For now, just coerce the Bavail to be uint64.

If the VFS layer might return -1 for one or the other of these then these casts
will be problematic and we'll need more safeguards.
2020-11-22 20:00:37 -05:00
Derek Collison
afa5cae58c Formalized PubAckResponse
Signed-off-by: Derek Collison <derek@nats.io>
2020-11-22 16:31:37 -08:00
Derek Collison
a50f96461b Allow to check for last sequence and last msgid for conditional publish
Signed-off-by: Derek Collison <derek@nats.io>
2020-11-22 15:12:00 -08:00
Derek Collison
bcb777150a Fix race
Signed-off-by: Derek Collison <derek@nats.io>
2020-11-22 10:24:32 -08:00
Derek Collison
b528b1f74e Allow complete $JS.API to be imported from another account.
Signed-off-by: Derek Collison <derek@nats.io>
2020-11-21 16:54:58 -08:00
Derek Collison
2e3c226729 Fix for service import cycles
Signed-off-by: Derek Collison <derek@nats.io>
2020-11-21 13:13:08 -08:00
Ivan Kozlovic
a0c4c5cb78 Add test with service import cycle
Not sure if this should be detected as misconfiguration or if
code need to be fixed to work properly.

Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
2020-11-20 15:38:55 -07:00
Ivan Kozlovic
4d51a41dfd Merge pull request #1727 from nats-io/tls-verify-and-impliict-allow
[ADDED] verify_cert_and_check_known_urls to tie subject alt name to url in cfg
2020-11-20 15:10:01 -07:00
Matthias Hanel
8fd1b66f66 Renaming to verify_cert_and_check_known_urls
Signed-off-by: Matthias Hanel <mh@synadia.com>
2020-11-20 16:56:44 -05:00
Derek Collison
beda0c397a Merge pull request #1729 from nats-io/js_export
Enable JetStream streams and consumer access to be exported
2020-11-20 11:28:44 -08:00
Matthias Hanel
eda80ff7b5 changing the option name verify_and_implicit_allow to verify_and_accept_known_urls
This follows the suggestion by phil. I added the and to be similar to verify_and_map.
I fixed a minor issue where the implicit verify could be overwriting an
explicitly configured one.

Signed-off-by: Matthias Hanel <mh@synadia.com>
2020-11-20 14:27:24 -05:00
Matthias Hanel
06e4e93185 Speeding up unit test fail case
Signed-off-by: Matthias Hanel <mh@synadia.com>
2020-11-20 13:57:34 -05:00
Matthias Hanel
f24aec4af7 Incorporating comments and fixed an issue where code was not invoked
had to change failing tests to use insecure as to not fail due to the
outgoing connection being not trusted.

Signed-off-by: Matthias Hanel <mh@synadia.com>
2020-11-20 13:57:34 -05:00
Matthias Hanel
74642e024e [Added] verify_and_implicit_allow to tie subject alt name to url in cfg
Only works for gateways and routes. When true the subject alt DNS name
must match one url in the corresponding configuration

Signed-off-by: Matthias Hanel <mh@synadia.com>
2020-11-20 13:57:34 -05:00
Derek Collison
a1c1ead39d Enable JetStream streams and consumer access to be exported to another account
Signed-off-by: Derek Collison <derek@nats.io>
2020-11-20 10:17:16 -08:00
Ivan Kozlovic
27c7a36446 Merge pull request #1728 from nats-io/sys-referencable-in-leaf
[Adding] ability to reference $SYS in leaf node config
2020-11-20 10:59:22 -07:00
Matthias Hanel
1229bed9fa [Adding] ability to reference $SYS in leaf node config
only do so if $SYS is the system account

Signed-off-by: Matthias Hanel <mh@synadia.com>
2020-11-19 22:32:42 -05:00
Ivan Kozlovic
a3af49152e Merge pull request #1725 from nats-io/fix_1722
[FIXED] LeafNode: duplicate queue messages in complex routing setup
2020-11-19 09:06:28 -07:00
Ivan Kozlovic
55b0f8d855 [FIXED] LeafNode: duplicate queue messages in complex routing setup
Suppose a cluster of 2 servers, let's call them leaf1 and leaf2.
These servers are routed and have a leaf connection to another
server, let's call it srv1.
They share the same cluster name.

If a queue subscriber runs on srv1 and a queue subscriber on the
same subject/group name runs on leaf1, if a requestor runs on
leaf2, the request should reach only one of the 2 queue subs.

The defect was that sometimes both queue subs would receive the
message.

The added test checks that only one reply is ever received and
that the local "leaf" cluster is preferred.

Resolves #1722

Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
2020-11-18 11:23:08 -07:00
Phil Pennock
bfd388e8b4 Bump beta version (.33) (#1724) 2020-11-18 10:49:42 -05:00
Ivan Kozlovic
16d7d032e1 Merge pull request #1719 from nats-io/fetch-acc-nkeys-only
Only fetch account jwt if the name is a proper public account key
2020-11-17 17:46:14 -07:00
Matthias Hanel
2c2a6e45fe Incorporating comment and making fetchAccount private
Signed-off-by: Matthias Hanel <mh@synadia.com>
2020-11-17 19:26:34 -05:00
Derek Collison
28d8a4be9c Merge pull request #1721 from nats-io/fsfix2
Fix for not properly recovering first sequence number on recovery.
2020-11-17 15:22:02 -08:00
Derek Collison
d358aaddf6 Fixes for filestore not remember first sequence when all messages deleted.
Thsi fixed a few minor bugs as well as the one where we did not remember our sequence numbers.

Signed-off-by: Derek Collison <derek@nats.io>
2020-11-17 15:04:57 -08:00
Ivan Kozlovic
f7f994ec7c Merge pull request #1720 from nats-io/rename-reject-unknown
Rename reject_unknown to reject_unknown_cluster
2020-11-17 15:57:20 -07:00
Matthias Hanel
3b4da21e07 Rename reject_unknown to reject_unknown_cluster
this is supposed to make it clearer what is being rejected

Signed-off-by: Matthias Hanel <mh@synadia.com>
2020-11-17 17:54:45 -05:00
Matthias Hanel
f69dc5cfd6 Only fetch account jwt if the name is a proper public account key
Signed-off-by: Matthias Hanel <mh@synadia.com>
2020-11-17 17:18:47 -05:00
Derek Collison
68416d291b Merge pull request #1717 from nats-io/ackReply
Optimize ackReply parsing
2020-11-17 11:44:34 -08:00
Ivan Kozlovic
86ea8b9b45 Merge pull request #1718 from AdamKorcz/master
Updated fuzzer
2020-11-17 12:02:35 -07:00
AdamKorcz
1191293cbf Updated fuzzer 2020-11-17 18:57:45 +00:00
Derek Collison
aa35d0818d Optimize ackReply parsing
Signed-off-by: Derek Collison <derek@nats.io>
2020-11-17 10:36:14 -08:00
Ivan Kozlovic
288ab48673 Merge pull request #1684 from AdamKorcz/master
[ADDED] Fuzzers
2020-11-17 11:34:54 -07:00
AdamKorcz
3126930654 Merge branch 'master' of https://github.com/AdamKorcz/nats-server 2020-11-17 18:15:08 +00:00
AdamKorcz
f6aca96696 Updated year in header 2020-11-17 18:13:21 +00:00
R.I.Pienaar
b9427db3c3 Merge pull request #1715 from ripienaar/lookup_request
support json requests for stream lookup
2020-11-17 19:04:29 +01:00
Ivan Kozlovic
5e9bad5b26 Test showing issue with filestore after a restart
I have pin-pointed that the issue started at this commit:
d737ccef55

This was PR: https://github.com/nats-io/nats-server/pull/1685

Prior to this PR, the test would pass.

Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
2020-11-17 09:01:36 -07:00
R.I.Pienaar
ca8cbcdc63 support subjects starting with {
still doesnt support a subject {}

Signed-off-by: R.I.Pienaar <rip@devco.net>
2020-11-17 16:33:22 +01:00
R.I.Pienaar
02eaf6d831 trim json text
Signed-off-by: R.I.Pienaar <rip@devco.net>
2020-11-17 16:06:12 +01:00
R.I.Pienaar
a4116cc0fa support json requests for stream lookup 2020-11-17 15:33:44 +01:00
Derek Collison
7f1fce5078 Merge pull request #1714 from nats-io/maxp
Make sure to honor MaxAckPending when streaming directly to consumers
2020-11-16 18:24:55 -08:00
Derek Collison
67f4bf1ac1 Make sure to honor MaxAckPending when streaming directly to consumers
Signed-off-by: Derek Collison <derek@nats.io>
2020-11-16 16:51:34 -08:00
Derek Collison
0156bea49a Merge pull request #1712 from nats-io/sendq
Decouple consumer from using stream's sendq.
2020-11-16 07:49:18 -08:00
Derek Collison
ce42addfe4 Merge pull request #1711 from nats-io/stream_lookup
Allow stream lookup by subject.
2020-11-16 05:59:13 -08:00