Derek Collison
d14968cb4f
Bump to 2.9.16-RC.6
...
Signed-off-by: Derek Collison <derek@nats.io >
2023-04-04 15:15:24 -07:00
Derek Collison
2167f39ccd
[IMPROVED] Do not block routes, leafnodes or gateways on received internal system msgs. ( #4026 )
...
To increase system stability in large NATS systems we do not want to
process inbound system messages that are destined to be processed by the
server itself to be processed inline on the inbound connection.
Signed-off-by: Derek Collison <derek@nats.io >
2023-04-04 15:13:02 -07:00
Derek Collison
3036bb8bc5
Fix for test
...
Signed-off-by: Derek Collison <derek@nats.io >
2023-04-04 14:43:46 -07:00
Derek Collison
208f4625df
Possibly de-race sysRequest ( #4017 )
...
This may fix a race condition in `sysRequest` where multiple inbox
responses could try to mutate the same input object, so instead we'll
let it instantiate its own, although it isn't clear to me yet why that
would happen in the first place.
Signed-off-by: Neil Twigg <neil@nats.io >
2023-04-04 14:40:11 -07:00
Derek Collison
b14a400df6
Fix for debugSubscribers and claims test
...
Signed-off-by: Derek Collison <derek@nats.io >
2023-04-04 14:36:16 -07:00
Derek Collison
3551c7b2bf
Convert over zReq to not have to call msgparts
...
Signed-off-by: Derek Collison <derek@nats.io >
2023-04-04 14:23:50 -07:00
Derek Collison
c323ec3086
Non-inline system callbacks need hdr and msg already split due to client context to split
...
Signed-off-by: Derek Collison <derek@nats.io >
2023-04-04 14:15:30 -07:00
Derek Collison
9f95e993e2
Do not inline inbound system messages to avoid blocking routes, gateways etc.
...
Signed-off-by: Derek Collison <derek@nats.io >
2023-04-04 13:53:21 -07:00
Neil Twigg
03a5a4deaf
Possibly de-race sysRequest
...
Signed-off-by: Neil Twigg <neil@nats.io >
2023-04-04 10:30:59 +01:00
Derek Collison
d5a525bde0
Bump to 2.9.16-RC.5
...
Signed-off-by: Derek Collison <derek@nats.io >
2023-04-03 21:23:35 -07:00
Derek Collison
34922df706
[IMPROVED] Make sure to never process next message requests inline. ( #4022 )
...
Signed-off-by: Derek Collison <derek@nats.io >
2023-04-03 21:22:31 -07:00
Derek Collison
ebe4f8957f
Spelling based on review feedback
...
Signed-off-by: Derek Collison <derek@nats.io >
2023-04-03 21:08:59 -07:00
Derek Collison
dcbefd5cc4
We can receive these on push consumers, so error if we do
...
Signed-off-by: Derek Collison <derek@nats.io >
2023-04-03 21:07:08 -07:00
Derek Collison
07b34f707f
Make sure to never process next message requests inline
...
Signed-off-by: Derek Collison <derek@nats.io >
2023-04-03 20:50:01 -07:00
Derek Collison
c9350a2d57
Only apply consumer entries if not recovering. ( #4021 )
...
These entries on restart should not be re-processed. This was causing
some failures on consumer tests that involved restarts.
Signed-off-by: Derek Collison <derek@nats.io >
2023-04-03 19:42:05 -07:00
Derek Collison
b0c3cf0dbd
Only apply consumer entries if not recovering
...
Signed-off-by: Derek Collison <derek@nats.io >
2023-04-03 17:22:50 -07:00
Derek Collison
9db08041c6
[IMPROVED] Raft layer improvements ( #4020 )
...
Two changes here.
1. Revert of a change regarding handling of leadership transfer entries
that caused instability in some tests and a bad upgrade experience.
2. Make sure if we detect that a stream or a consumer is already running
the monitoring routines that we do not stop the underlying raft group
since it will be being used in the monitor routine and would stall that
asset.
Signed-off-by: Derek Collison <derek@nats.io >
2023-04-03 15:24:48 -07:00
Derek Collison
7d3ec51d79
Fix for flapping test
...
Signed-off-by: Derek Collison <derek@nats.io >
2023-04-03 14:46:59 -07:00
Derek Collison
59175c491f
Fix for a datarace
...
Signed-off-by: Derek Collison <derek@nats.io >
2023-04-03 14:46:57 -07:00
Derek Collison
b806a8e7e7
Do not opt-out of normal processing for leadership transfers, but make sure they are only processed if explicitly new
...
Signed-off-by: Derek Collison <derek@nats.io >
2023-04-03 14:46:55 -07:00
Derek Collison
9dd727034a
Make sure to not stop raft layer when we detect we are already running the monitor
...
Signed-off-by: Derek Collison <derek@nats.io >
2023-04-03 14:46:47 -07:00
Derek Collison
18656412b8
Allow overriding target branch in on-demand nightly image builds ( #4019 )
...
This allows us to manually specify a branch to build the nightly image
from when dispatching builds manually.
Signed-off-by: Neil Twigg <neil@nats.io >
2023-04-03 11:13:40 -07:00
Neil Twigg
7f9e6dad38
Allow overriding target branch in on-demand nightly image builds
...
Signed-off-by: Neil Twigg <neil@nats.io >
2023-04-03 17:00:22 +01:00
Derek Collison
ea61b0028c
No inline jetstream msg processing, always queue inbound ( #4018 )
...
Signed-off-by: Derek Collison <derek@nats.io >
2023-04-03 08:36:24 -07:00
Derek Collison
6b01a21965
No inline jetstream msg processing, always queue inbound
...
Signed-off-by: Derek Collison <derek@nats.io >
2023-04-03 08:27:52 -07:00
Derek Collison
94278e731a
More tweaks to test due to slow network proxy being more accurate
...
Signed-off-by: Derek Collison <derek@nats.io >
2023-04-02 19:57:34 -07:00
Derek Collison
66e7b6f4bd
Bump to 2.9.16-RC.4
...
Signed-off-by: Derek Collison <derek@nats.io >
2023-04-02 19:49:53 -07:00
Derek Collison
5afcb6c13c
Fix for flapping test, network proxy more accurate now so rtt needed to be tweaked
...
Signed-off-by: Derek Collison <derek@nats.io >
2023-04-02 19:06:42 -07:00
Derek Collison
b2b3ed9a03
Cherry-pick #3733 (Refactor outbound queues, remove dynamic sizing, add buffer reuse) ( #3965 )
...
This brings #3733 forward from `dev` into `main`, to go into the next
release.
Signed-off-by: Neil Twigg <neil@nats.io >
2023-04-02 18:56:28 -07:00
Derek Collison
14ad9837c1
[IMPROVED] Protect against concurrent creation of streams and consumers. ( #4013 )
...
Also make sure we have exited monitoring routines when doing resets for
both streams and consumers.
Signed-off-by: Derek Collison <derek@nats.io >
2023-04-02 18:29:04 -07:00
Derek Collison
ff3f102cdd
Fix for datarace in healthcheck
...
Signed-off-by: Derek Collison <derek@nats.io >
2023-04-02 16:30:13 -07:00
Derek Collison
d5ac4d283a
Fix for flapping test, can return invalid sequence as well
...
Signed-off-by: Derek Collison <derek@nats.io >
2023-04-02 16:18:23 -07:00
Derek Collison
64b22011dc
Better use of LoadAndStore based on review feedback
...
Signed-off-by: Derek Collison <derek@nats.io >
2023-04-02 14:50:22 -07:00
Derek Collison
1fb1efd748
Make sure to remove any inflight entries when done
...
Signed-off-by: Derek Collison <derek@nats.io >
2023-04-02 14:41:49 -07:00
Derek Collison
e6447c982a
Protect against concurrent creation of streams and consumers.
...
Also make sure we have exited monotoring routines when doing resets for both streams and consumers.
Signed-off-by: Derek Collison <derek@nats.io >
2023-04-02 14:29:52 -07:00
Derek Collison
f3cab83ccf
Bump to 2.9.16-RC.3
...
Signed-off-by: Derek Collison <derek@nats.io >
2023-04-02 04:24:21 -07:00
Derek Collison
d62dbb7635
[FIXED] Concurrent map access for preAcks. ( #4012 )
...
Also some raft and interest based consumers improvements.
Some IO guards around removal of files.
Signed-off-by: Derek Collison <derek@nats.io >
2023-04-02 04:23:25 -07:00
Derek Collison
58ca525b3b
Process replicated ack regardless of store update. Delay but still stepdown
...
Signed-off-by: Derek Collison <derek@nats.io >
2023-04-02 03:53:16 -07:00
Derek Collison
a8bd2793d5
Fix concurrent map bug on preAcks.
...
Use monitor check for streams like consumers.
Make sure to stop raft layer if exiting monitorConsumer early.
Allow consumers to force a snapshot on leadership change.
Signed-off-by: Derek Collison <derek@nats.io >
2023-04-02 03:53:11 -07:00
Derek Collison
874b2b2e02
Hold the lock while checking health since we could update catchup state.
...
Do not stepdown right away when executing leadership transfer, wait for the commit.
Signed-off-by: Derek Collison <derek@nats.io >
2023-04-02 03:53:08 -07:00
Derek Collison
b5358fa4b3
Wait for shutdown and sleep to let state build up
...
Signed-off-by: Derek Collison <derek@nats.io >
2023-04-02 03:53:05 -07:00
Derek Collison
b752b8b30d
Snapshot on clean shutdown if needed or interest based retention
...
Signed-off-by: Derek Collison <derek@nats.io >
2023-04-02 03:53:03 -07:00
Derek Collison
e54019f87f
All should be lowercase
...
Signed-off-by: Derek Collison <derek@nats.io >
2023-04-02 03:53:01 -07:00
Derek Collison
872a9e7927
Add in monitor status similar to consumer
...
Signed-off-by: Derek Collison <derek@nats.io >
2023-04-02 03:52:59 -07:00
Derek Collison
df4982948c
Gate remove calls, disqualify delivered and ack updates quicker
...
Signed-off-by: Derek Collison <derek@nats.io >
2023-04-02 03:52:56 -07:00
Derek Collison
4b8229ee42
Do not hold js lock for health check, use healthy not current for meta
...
Signed-off-by: Derek Collison <derek@nats.io >
2023-04-02 03:52:54 -07:00
Derek Collison
e2839e9ec1
Fix for flapper
...
Signed-off-by: Derek Collison <derek@nats.io >
2023-04-02 03:52:43 -07:00
Derek Collison
fbaeaf905f
Updates to preacks when multiple consumers are mutually exclusive ( #4007 )
...
When consumers where mutually exclusive and acks came in before a
message we did not properly cleanup the messages.
Signed-off-by: Derek Collison <derek@nats.io >
2023-03-31 11:35:29 -07:00
Derek Collison
ad5bb366a0
Updates to preacks when multiple consumers are present but mutually exlusive (filtered).
...
Signed-off-by: Derek Collison <derek@nats.io >
2023-03-31 10:43:28 -07:00
Derek Collison
c194047caf
Bump to 2.9.16-RC.2
...
Signed-off-by: Derek Collison <derek@nats.io >
2023-03-30 21:23:51 -07:00