Commit Graph

6791 Commits

Author SHA1 Message Date
Tomasz Pietrek
daadbc07cb Merge pull request #3919 from nats-io/jarema/fix-service-export-nil-pointer 2023-02-28 16:51:04 +01:00
Tomasz Pietrek
10c2c387b7 Fix panic if serviceExport is nil
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
2023-02-28 15:36:37 +01:00
Tomasz Pietrek
bca45c28aa Merge pull request #3918 from nats-io/jarema/fix-claims-update-with-headers
Fix JWT claims update if headers are passed in request
2023-02-28 11:43:57 +01:00
Tomasz Pietrek
8732022d26 Fix JWT claims update if headers are passed in request
Claims update message requires only payload to be passed,
but passing headers should not fail the request.
This change ensures we extract payload from raw message
before decoding it.
Before this change, passing claims update with headers
would return cryptic `expected x chunks` error.

Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
2023-02-28 11:09:18 +01:00
Neil
1db3934b46 Merge pull request #3915 from nats-io/jsz-mon-raft-group
[main] Add raft query parameter to /jsz to include raft group info
2023-02-27 18:04:45 +00:00
Waldemar Quevedo
74b703549d Add raft query parameter to /jsz to include raft group info
Signed-off-by: Waldemar Quevedo <wally@nats.io>
2023-02-27 05:42:11 -08:00
Derek Collison
67ba9868f1 Merge pull request #3911 from nats-io/raft-spin
[FIXED] If a truncate for a raft WAL failed we could spin.
2023-02-25 19:40:44 -08:00
Derek Collison
4fa0ea32c3 [FIXED] If a truncate for a raft WAL failed we could spin.
Signed-off-by: Derek Collison <derek@nats.io>
2023-02-25 19:07:27 -08:00
Derek Collison
65127d636e Merge pull request #3910 from nats-io/store-speedups
[FIXED] JetStream Store fixes and speedups.
2023-02-25 17:51:21 -08:00
Derek Collison
daacbf5580 Added optimized store NumPending() call.
Optimized and fixed a bug in filestore filteredPending().
Optimized memstore FilteredState().

Added comprehensive tests for NumPending() and FilteredState().

Signed-off-by: Derek Collison <derek@nats.io>
2023-02-25 17:26:26 -08:00
Derek Collison
24c2f3b452 Improved performance of subjects details for stream info.
This version avoids all disk IO in the filestore version.

Signed-off-by: Derek Collison <derek@nats.io>
2023-02-24 17:22:18 -08:00
Derek Collison
87a1846822 Merge pull request #3907 from nats-io/raft-fix
[FIXED] Snapshots would not compact through applied.
2023-02-23 22:44:45 -08:00
Derek Collison
ea2bfad8ea Fixed bug where snapshot would not compact through applied. This mean a subsequent request for exactly applied would return that entry only not the full state snapshot.
Fixed bug where we would not snapshot when we should.

Signed-off-by: Derek Collison <derek@nats.io>
2023-02-23 22:19:37 -08:00
Derek Collison
8169a117e4 Merge pull request #3861 from nats-io/jarema/fix-scaleup-with-maxage
Fix new replicas late MaxAge expiry
2023-02-23 16:41:26 -08:00
Tomasz Pietrek
02ba78454d Fix new replicas late MaxAge expiry
This commit fixes the issue when scaling Stream with MaxAge
and some older messages stored. Until now, old messages were not properly
expired on new replicas, because new replicas first expiry timer
was set to MaxAge duration.
This commit adds a check if received messages expiry happens before
MaxAge, meaning they're messages older than the replica.
https://github.com/nats-io/nats-server/issues/3848

Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
2023-02-24 00:46:02 +01:00
Derek Collison
79df099c44 Merge pull request #3905 from nats-io/raft-stepdown-logic
[IMPROVED] Make sure preferred peer for stepdown is healthy.
2023-02-23 13:58:58 -08:00
Derek Collison
45859e6476 Make sure preferred peer for stepdown is healthy.
Signed-off-by: Derek Collison <derek@nats.io>
2023-02-23 13:06:13 -08:00
Derek Collison
9d972642e9 Merge pull request #3904 from nats-io/meta-improvements
[IMPROVED] When becoming meta-leader optionally send current snapshot to followers.
2023-02-23 10:54:14 -08:00
Derek Collison
d347cb116a When becoming leader optionally send current snapshot to followers if caught up.
This can help sync on restarts and improve ghost ephemerals. Also added more code to suppress respnses and API audits when we know we are recovering.

Signed-off-by: Derek Collison <derek@nats.io>
2023-02-23 10:30:36 -08:00
Derek Collison
8d73757129 Merge pull request #3903 from nats-io/neil/codeowners
Set code owners, tweak PR template
2023-02-23 10:24:52 -08:00
Neil Twigg
8729ff4015 Set code owners, tweak PR template 2023-02-23 10:48:20 +00:00
Derek Collison
f2c5e7ec02 Bump to 2.9.15-RC.2
Signed-off-by: Derek Collison <derek@nats.io>
2023-02-22 19:54:13 -08:00
Derek Collison
7aa407a757 Merge pull request #3901 from nats-io/consumer-create-perf
[IMPROVED] Consumer create performance in some circumstances.
2023-02-22 19:53:13 -08:00
Derek Collison
2972c11be6 Improve consumer create performance.
In cases where we had a large subject space, a filestore with many msg blocks, and a filtered consumer with a wildcard filtered subject, creating a consumer could take more memory and time then we wanted.
This improvement works when the consumer is DeliverAll and we used the upper layer in memory psim structure to scan but only in memory and avoid a file read for each msg block.

Signed-off-by: Derek Collison <derek@nats.io>
2023-02-22 19:42:02 -08:00
Derek Collison
f16a7d8559 Skip test for now
Signed-off-by: Derek Collison <derek@nats.io>
2023-02-22 15:49:48 -08:00
Derek Collison
adebb650d4 Merge pull request #3900 from nats-io/kv-accounting
[FIXED] KV accounting errors under heavy concurrent usage
2023-02-22 14:42:19 -07:00
Derek Collison
d03d8e9d93 When having a max msgs per subject (e.g. KV) under heavy concurrent usage could skew the accounting for the underlying filestore.
Signed-off-by: Derek Collison <derek@nats.io>
2023-02-22 12:50:43 -08:00
Derek Collison
591f2b754d Merge pull request #3898 from nats-io/neil/consumercompact
Install snapshot and compact when WAL grows, even when no state changes occur
2023-02-22 13:18:01 -07:00
Neil Twigg
cfea34c80c Install snapshot and compact when WAL grows, even when no state changes occur 2023-02-22 20:00:57 +00:00
Derek Collison
b19077c2e9 Bump to 2.9.15-RC.1
Signed-off-by: Derek Collison <derek@nats.io>
2023-02-21 08:35:30 -08:00
Derek Collison
baf2e47c06 Merge pull request #3894 from nats-io/neil/ipqueue
Refactor `ipQueue` to use generics
2023-02-21 09:31:26 -07:00
Neil Twigg
68961ffedd Refactor ipQueue to use generics, reduce allocations 2023-02-21 14:50:09 +00:00
Derek Collison
18b5aca499 Merge pull request #3892 from nats-io/consumer-fixes
[FIXED] Consumer fixes and improvements on state management.
2023-02-20 19:17:39 -07:00
Derek Collison
3c64d07691 Warn of consumer state update failures.
Signed-off-by: Derek Collison <derek@nats.io>
2023-02-20 17:28:11 -08:00
Derek Collison
53cf6635e2 Merge pull request #3893 from nats-io/raft-fixes
[FIXED] Spurious "Error storing entry to WAL" log messages
2023-02-20 18:23:40 -07:00
Derek Collison
2a9f085d55 Merge branch 'main' into raft-fixes 2023-02-20 15:43:46 -07:00
Derek Collison
e028b7230a Need to compact wal on snapshot to pindex+1
Signed-off-by: Derek Collison <derek@nats.io>
2023-02-20 14:37:37 -08:00
Neil
7e67ec5b1f Merge pull request #3891 from nats-io/neil/pindex
Off-by-one on RAFT pindex
2023-02-20 22:35:57 +00:00
Derek Collison
ad8aa7c0c5 Merge pull request #3887 from MauriceVanVeen/main
[FIXED] Using partition with multiple wildcard token positions
2023-02-20 13:59:49 -07:00
Derek Collison
d2179e0939 Make sure to also cleanup pending if below our stream ack floor
Signed-off-by: Derek Collison <derek@nats.io>
2023-02-20 11:56:37 -08:00
Derek Collison
b6149c51f0 Make sure to clean up redelivered state on purge.
Make sure to update ack floors on messages being expired out from underneath of us.

Signed-off-by: Derek Collison <derek@nats.io>
2023-02-20 11:16:12 -08:00
Neil Twigg
20980dc324 Off-by-one on RAFT pindex 2023-02-20 18:16:10 +00:00
Maurice van Veen
05695d304c Fixed a bug where partition was used with multiple wildcard token position 2023-02-20 10:27:29 +01:00
Derek Collison
6c9a9fb45e Fixed bug that would lose ack pending state during partial stream purge.
General code cleanup to be more correct.

Signed-off-by: Derek Collison <derek@nats.io>
2023-02-19 14:21:53 -08:00
Derek Collison
5c6b3b620a Merge pull request #3885 from nats-io/jarema/improve-interest-test
Improve test for consumer with inactivity threshold
2023-02-19 10:36:36 -07:00
Tomasz Pietrek
337a9f2cbd Improve test for consumer with inactivity threshold
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
2023-02-19 17:57:09 +01:00
Derek Collison
8fc34596f1 Merge pull request #3886 from nats-io/process-connect-fix-main
Check if connection name was already set when storing it
2023-02-19 09:45:17 -07:00
Waldemar Quevedo
beb179ec15 Check if connection name was already set when storing it
Signed-off-by: Waldemar Quevedo <wally@nats.io>
2023-02-19 07:58:56 -08:00
Derek Collison
b3f0dbdde4 Merge pull request #3884 from nats-io/fix-consumer-cleanup
[FIXED] Named push consumers with inactive thresholds deleted when still active.
2023-02-19 08:51:37 -07:00
Derek Collison
06fd81d096 Fixed a bug where a named consumer under interest policy was spinning up inactive threshold timers in all replicas not just the leader.
Signed-off-by: Derek Collison <derek@nats.io>
2023-02-19 06:08:43 -08:00