gogrlx/nats-server
1
0
Fork 0
mirror of https://github.com/gogrlx/nats-server.git synced 2026-04-02 03:38:42 -07:00
Code Issues Packages Projects Releases Wiki Activity
8,388 Commits 30 Branches 48 Tags
ea0843fe26671a72a19a70367bbb05612be7d990
Commit Graph

8388 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Neil Twigg
ea0843fe26 Update DEPENDENCIES.md 
Signed-off-by: Neil Twigg <neil@nats.io>
 2023-10-12 11:21:45 +01:00
Byron Ruth
a25af02c73 Bump Travis Go version to 1.21.3 and 1.20.10 (#4649) 
Signed-off-by: Byron Ruth <byron@nats.io>
 2023-10-11 13:46:17 -04:00
Derek Collison
38794e5af9 Bump to 2.10.3-RC.1 
Signed-off-by: Derek Collison <derek@nats.io>
 2023-10-11 08:26:09 -07:00
Derek Collison
94545f3206 [FIXED] Compaction with compression and added out of band compaction (#4645) 
This will also reclaim more space for streams with lots of interior
deletes.


Signed-off-by: Derek Collison <derek@nats.io>
 2023-10-11 08:22:10 -07:00
Derek Collison
842d600e3f Grab blk fn while mb lock held 
Signed-off-by: Derek Collison <derek@nats.io>
 2023-10-11 07:54:36 -07:00
Derek Collison
9a551186d8 Fixed a crash in MQTT outgoing PUBREL (#4646) 
This really was a cut/paste/typo error, the `else` should not have been
there. Came up in my testing.

The effect was that when there was a pending `PUBREL` in JetStream, and
a matching client connects - we would sometimes attempt to deliver the
PUBREL immediately once connected. `cpending` was already initialized,
but the pubrel map was not (yet).
 2023-10-10 19:09:43 -07:00
Lev Brouk
de1282c98d Fixed a crash in MQTT outgoing PUBREL 
This really was a cut/paste/typo error.

The effect was that when there was a pending PUBREL in JetStream, we would sometimes attempt to deliver it immediately once the client connected, cpending was already initialized, but the pubrel map was not (yet).
 2023-10-10 18:08:18 -07:00
Derek Collison
f4387ec74e Fix for compaction with compression and added an out of band compaction in syncBlocks to reclaim more space. 
Signed-off-by: Derek Collison <derek@nats.io>
 2023-10-10 17:17:55 -07:00
Neil
6a5304cfac Add CONTRIBUTING.md, simplify PR template (#4619) 
This simplifies the PR template, which is a bit cumbersome, and instead
replaces it with a simpler notice that includes a template sign-off and
a new `CONTRIBUTING.md` document.

Signed-off-by: Neil Twigg <neil@nats.io>
Co-authored-by: Byron Ruth <byron@nats.io>
 2023-10-10 08:39:38 -04:00
Neil
8b39af0c5f Bump v2.10.3 (#4635) 2023-10-10 10:00:40 +01:00
Ivan Kozlovic
eadb19f539 Fixed code coverage GithHub Action (#4641) 
Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
 2023-10-09 15:21:24 -06:00
Ivan Kozlovic
0a4f2e642e Fixed code coverage GithHub Action 
Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
 2023-10-09 13:07:54 -06:00
Waldemar Quevedo
72430e7998 Rename MQTT test.yaml to MQTT_test.yaml (#4637) 2023-10-06 15:39:51 -07:00
Byron Ruth
4ab65b1871 Bump v2.10.3 
Signed-off-by: Byron Ruth <byron@nats.io>
 2023-10-06 16:39:45 -04:00
Byron Ruth
203c4b9c2d Release v2.10.2 (#4634) 2023-10-06 16:30:39 -04:00
Byron Ruth
f8c9d8e686 Release v2.10.2 
Signed-off-by: Byron Ruth <byron@nats.io>
 2023-10-06 15:23:06 -04:00
Byron Ruth
95dd8e7a71 Pin Go versions in Travis CI (#4633) 
Signed-off-by: Byron Ruth <byron@nats.io>
 2023-10-06 12:09:27 -07:00
Derek Collison
0c3609ed2a Bump to 2.10.2-RC.15 
Signed-off-by: Derek Collison <derek@nats.io>
 2023-10-06 09:58:55 -07:00
Derek Collison
f29c7863e7 [FIXED] Setting initial min on dmap caused subtle bugs with dmap. (#4631) 
Under heavy load with max msgs per subject of 1 the dmap, when
considered empty and resetting the initial min, could cause lookup
misses that would lead to excess messages in a stream and longer restore
issues.

Signed-off-by: Derek Collison <derek@nats.io>
 2023-10-06 09:58:17 -07:00
Derek Collison
dd646f6b71 Set initial min on dmap caused subtle bugs with dmap. Some minor cleanup. 
Signed-off-by: Derek Collison <derek@nats.io>
 2023-10-06 09:42:09 -07:00
Lev
beee6fc72a [FIXED] MQTT PUBREL header incompatibility (#4616) 
https://hivemq.github.io/mqtt-cli/docs/test/ pointed out the
incompatibility.
 2023-10-05 08:07:50 -07:00
Waldemar Quevedo
4e414f1f05 Skip processing consumer assignments after JS has shutdown (#4625) 
Signed-off-by: Waldemar Quevedo <wally@nats.io>
 2023-10-04 13:17:22 -07:00
Neil
4c791d6288 Reduce allocations in WebSockets (#4623) 2023-10-04 20:07:21 +01:00
Neil Twigg
7124dc7bdc Revert changes to nbPoolPut, force compressor to forget byte buffer 
Signed-off-by: Neil Twigg <neil@nats.io>
 2023-10-04 17:41:36 +01:00
Neil Twigg
e20ca9043f Don't append empty slices in the unfragmented path 
Signed-off-by: Neil Twigg <neil@nats.io>
 2023-10-04 17:18:47 +01:00
Neil Twigg
6b65452bc7 Reduce allocations in WebSocket compression 
Signed-off-by: Neil Twigg <neil@nats.io>
 2023-10-04 12:36:32 +01:00
Derek Collison
dbe700d192 Bump to 2.10.0-RC.14 
Signed-off-by: Derek Collison <derek@nats.io>
 2023-10-03 16:11:30 -07:00
Derek Collison
3f1afb4ca2 [IMPROVED] Bumped inflight updates to 16 and move one lock to rlock. (#4621) 
Signed-off-by: Derek Collison <derek@nats.io>
 2023-10-03 16:10:59 -07:00
Derek Collison
21e272360d [IMPROVED] Memory growth on compressed websocket connections. (#4620) 
Holding onto the compressor and not recycling the internal byte slice
could cause havoc with GC.

This needs to be improved but this at least should allow the GC to
cleanup more effectively.

Signed-off-by: Derek Collison <derek@nats.io>
 2023-10-03 15:37:01 -07:00
Derek Collison
2d21bc7008 Fix datarace 
Signed-off-by: Derek Collison <derek@nats.io>
 2023-10-03 15:35:20 -07:00
Derek Collison
1ccc6dbf30 Bumped inflight updates to 16 and move one lock to rlock. 
Signed-off-by: Derek Collison <derek@nats.io>
 2023-10-03 15:01:34 -07:00
Derek Collison
2f1a384bcb Holding onto the compressor and not recycling the interbal byte slice was causing havoc with GC. 
This needs to be improved but this at least should allow the GC to cleanup more effectively.

Signed-off-by: Derek Collison <derek@nats.io>
 2023-10-03 14:39:00 -07:00
Derek Collison
195227edfd Bump to 2.10.0-RC.12 
Signed-off-by: Derek Collison <derek@nats.io>
 2023-10-02 09:53:30 -07:00
Derek Collison
e42b8ce02a [IMPROVED] Optimize locking for consumer info API (#4615) 
Signed-off-by: Derek Collison <derek@nats.io>
 2023-10-02 09:52:58 -07:00
Derek Collison
e4ca15c2c3 Optimize locking for consumer info 
Signed-off-by: Derek Collison <derek@nats.io>
 2023-10-02 09:22:44 -07:00
Derek Collison
4165f869d2 Bump to 2.10.2-RC.11 
Signed-off-by: Derek Collison <derek@nats.io>
 2023-10-01 08:18:28 -07:00
Derek Collison
00839280fb [IMPROVED] Reduce contention for high connections in a JetStream enabled account with high API usage. (#4613) 
Several strategies are used which are listed below.

1. Checking a RaftNode to see if it is the leader now uses atomics.
2. Checking if we are the JetStream meta leader from the server now uses
an atomic.
3. Accessing the JetStream context no longer requires a server lock,
uses atomic.Pointer.
4. Filestore syncBlocks would hold msgBlock locks during sync, now does
not.

Signed-off-by: Derek Collison <derek@nats.io>
 2023-10-01 08:17:15 -07:00
Derek Collison
dba03dbc2f Optimizations to reduce contention for high connections in a JetStream enabled account with high API usage. 
Several strategies which are listed below.

1. Checking a RaftNode to see if it is the leader now uses atomics.
2. Checking if we are the JetStream meta leader from the server now uses an atomic.
3. Accessing the JetStream context no longer requires a server lock, uses atomic.Pointer.
4. Filestore syncBlocks would hold msgBlock locks during sync, now does not.

Signed-off-by: Derek Collison <derek@nats.io>
 2023-09-30 14:52:15 -07:00
Derek Collison
6eee1f736b Fix consumer info if consumer was closed (#4610) 
Co-authored-by: Derek Collison <derek@nats.io>
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Signed-off-by: Derek Collison <derek@nats.io>
 2023-09-29 13:47:55 -07:00
Tomasz Pietrek
1f4b986125 Fix consumer info if consumer was closed 
Co-authored-by: Derek Collison <derek@nats.io>
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Signed-off-by: Derek Collison <derek@nats.io>
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
 2023-09-29 21:40:55 +02:00
Neil
15b46117af Add more pprof labels to consumers, sources, mirrors (#4609) 
Signed-off-by: Neil Twigg <neil@nats.io>
 2023-09-29 19:38:38 +01:00
Neil Twigg
212d92ca7e Add more pprof labels to consumers, sources, mirrors 
Signed-off-by: Neil Twigg <neil@nats.io>
 2023-09-29 19:12:47 +01:00
Derek Collison
720ac605a2 Bump to 2.10.0-RC.10 
Signed-off-by: Derek Collison <derek@nats.io>
 2023-09-28 14:43:08 -07:00
Derek Collison
c9fa001ebf [IMPROVED] Add in additional warning when subject skew detected (#4606) 
Signed-off-by: Derek Collison <derek@nats.io>
 2023-09-28 14:42:29 -07:00
Derek Collison
fa5b7afcb6 [FIXED] Do not bypass authorization blocks when turning on $SYS account access (#4605) 
Only setup auto no-auth for $G account iff no authorization block was
defined.

Signed-off-by: Derek Collison <derek@nats.io>

Resolves #4535
 2023-09-28 14:17:24 -07:00
Derek Collison
cb74f3f26e Add in additional warning when subject skew detected 
Signed-off-by: Derek Collison <derek@nats.io>
 2023-09-28 14:16:27 -07:00
Derek Collison
2737c56352 Only setup auto no-auth for $G account iff no authorization block was defined. 
Signed-off-by: Derek Collison <derek@nats.io>
 2023-09-28 13:51:45 -07:00
Derek Collison
3d5564bbb1 [FIXED] Flapping TestMQTTLockedSession (#4604) 
A test-only fix.

I can not reproduce the flapping behavior, but did see a race during
debugging suggesting that the CONNACK is delivered to the test before
`mqttProcessConnect` finishes and releases the record.
 2023-09-28 13:16:46 -07:00
Lev Brouk
214711654e PR feedback: use checkFor 2023-09-28 12:42:18 -07:00
Lev Brouk
a05d4416ef PR feedback: nit 2023-09-28 12:02:35 -07:00