Commit Graph

6493 Commits

Author SHA1 Message Date
Ivan Kozlovic
ef00281bc2 Bump to v2.9.7-beta as per release process
Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
2022-11-04 10:46:45 -06:00
Ivan Kozlovic
289a9e1be0 Merge pull request #3609 from nats-io/release_2_9_6
Release v2.9.6
2022-11-04 09:56:18 -06:00
Ivan Kozlovic
00a7b4af1e Release v2.9.6
Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
2022-11-04 09:44:54 -06:00
Ivan Kozlovic
a2e791d26d Merge pull request #3608 from nats-io/js_scale_down_no_quorum
[FIXED] JetStream: Stream scale down while it has no quorum
2022-11-04 09:33:08 -06:00
Ivan Kozlovic
ca237bdfa0 [FIXED] JetStream: Stream scale down while it has no quorum
If a stream R2 had one of its server network-partitioned and at
that time the stream was edited to be scaled down to an R1 it
would cause the stream to no longer have quorum even when the
network partition is resolved.

Signed-off-by: Derek Collison <derek@nats.io>
Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
2022-11-04 09:08:31 -06:00
Ivan Kozlovic
3e467fc114 Merge pull request #3606 from nats-io/fix_3559
[FIXED] JetStream: Sources with OptStartTime gets redelivered
2022-11-03 16:25:00 -06:00
Ivan Kozlovic
c16ccd34c3 [FIXED] JetStream: Sources with OptStartTime gets redelivered
If start by time is before what we remember during recovery use that instead

Resolves #3559

Signed-off-by: Derek Collison <derek@nats.io>
Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
2022-11-03 16:09:06 -06:00
Derek Collison
c9fd776889 Merge pull request #3605 from nats-io/fix-3606
[FIXED] Notifying waiting pull consumers on consumer or parent stream deletion.
2022-11-03 13:05:47 -07:00
Derek Collison
72ff2edb5f Fix for #3603.
Signed-off-by: Derek Collison <derek@nats.io>
2022-11-03 12:46:41 -07:00
Ivan Kozlovic
edf0fe31b0 Merge pull request #3604 from nats-io/fix_3191
[FIXED] LeafNode: possible duplicate messages in complex setup
2022-11-03 12:57:36 -06:00
Ivan Kozlovic
91c84c03c2 [FIXED] LeafNode: possible duplicate messages in complex setup
This is specific to setup described [here](https://github.com/nats-io/nats-server/issues/3191#issuecomment-1296974382)
and does not require JetStream to be reproduced. The added test
reproduces the above setup but without JetStream enabled in
the accounts.

Each cluster has a leafnode for a given account to the other
cluster. The accounts import/export a subject. When a consumer
is connected to cluster "B" and the producer is on cluster "A"
there was a duplicate message. Due to shadow subscription caused
by the import/export rules, an additional subscription was
sent across the leafnode.

Resolves #3191

Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
2022-11-03 12:34:01 -06:00
Derek Collison
0f8aa11422 Merge pull request #3601 from nats-io/lag-warning
[FIXED] On stream proposal failures we could accidentally warn about high stream lag.
2022-11-02 14:48:29 -07:00
Derek Collison
56919ebc97 On stream proposal failures we could accidentally warn on high stream lag.
We were not taking the clfs into account.

Signed-off-by: Derek Collison <derek@nats.io>
2022-11-02 14:40:31 -07:00
Ivan Kozlovic
ae558469ea Merge pull request #3600 from nats-io/change_nightly_from_main_to_dev
Change code coverage and nightly to build from dev instead of main [ci skip]
2022-11-02 12:35:28 -06:00
Ivan Kozlovic
4187413281 Change nightly to build from dev instead of main [ci skip]
Also updated some of the actions to avoid some deprecation warnings

Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
2022-11-02 11:52:36 -06:00
Ivan Kozlovic
df067e6040 Merge pull request #3599 from nats-io/js_monitor_consumer
[FIXED] JetStream: possible panic on some rare cases
2022-11-02 10:54:11 -06:00
Ivan Kozlovic
ab4470ccdc [FIXED] JetStream: possible panic on some rare cases
Very difficult to reproduce. Had to run TestJetStreamSuperClusterMoveCancel
in covermode=atomic on a slow machine to hit the condition where
the monitorConsumer go routine is started by RAFT node is nil,
which caused the warning message to produce the panic (since n is nil)

Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
2022-11-02 10:02:09 -06:00
Ivan Kozlovic
2321eafb0c Bump version to 2.9.6-beta as per release process
Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
2022-11-01 16:23:50 -06:00
Ivan Kozlovic
ceebf53cf6 Merge pull request #3597 from nats-io/release_2_9_5
Release v2.9.5
2022-11-01 15:33:02 -06:00
Ivan Kozlovic
c16f60add5 Release v2.9.5
Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
2022-11-01 15:15:06 -06:00
Ivan Kozlovic
32041d98d7 Merge pull request #3596 from nats-io/js_process_snap
[FIXED] JetStream: processing of snapshot with expired messages
2022-11-01 13:27:29 -06:00
Ivan Kozlovic
55e651c118 [FIXED] JetStream: processing of snapshot with expired messages
The issue that a "first sequence mismatch" during processing of
a snapshot was causing the state to be reset and caused a lot
of catchup from the follower. An attempt to fix that in PR #3567
caused an issue that was addressed in PR #3589. However, this was
then causing the follower to sometime never able to catchup or
took a very long time.
This PR - we believe - addresses the original and subsequent issues.

Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
2022-11-01 12:58:45 -06:00
Derek Collison
56bd22f536 Merge pull request #3595 from nats-io/max-msgs-per-update
[FIXED] Honor MaxMsgsPerSubject during a stream config update.
2022-11-01 09:41:55 -07:00
Derek Collison
1fa5e73177 Honor MaxMsgsPerSubject when a stream config is updated, including enforcing a lower limit.
Signed-off-by: Derek Collison <derek@nats.io>
2022-10-31 17:25:20 -07:00
Ivan Kozlovic
4f252d3ef8 Merge pull request #3592 from nats-io/fix_flapper
Fixing a flapper
2022-10-28 14:34:38 -06:00
Ivan Kozlovic
fe588dc9ea Fixing a flapper
Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
2022-10-28 13:45:58 -06:00
Ivan Kozlovic
a0719ec7a7 Merge pull request #3591 from aopetrov86/less-optimistic-cache-hit-rate
[FIXED] Sublist's cache hit rate would be wrong in presence of multiple accounts
2022-10-28 09:29:42 -06:00
Александр Петров
8eb430bfff add test 2022-10-28 20:16:40 +05:00
Александр Петров
19f63bee65 less optimistic cache hit rate 2022-10-28 11:36:46 +05:00
Ivan Kozlovic
3f0f3d7416 Bump version to 2.9.5-beta.1
Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
2022-10-27 19:15:01 -06:00
Derek Collison
d6b4bdee69 Merge pull request #3589 from nats-io/sreq-nil
[FIXED] Move code that references sreq past the check for nil
2022-10-27 18:10:41 -07:00
Derek Collison
121bf6ebb5 Move to past check for nil
Signed-off-by: Derek Collison <derek@nats.io>
2022-10-27 17:30:07 -07:00
Ivan Kozlovic
3a5f465115 Bump to 2.9.5-beta as per release process
Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
2022-10-27 17:15:00 -06:00
Ivan Kozlovic
0b9529469e Merge pull request #3588 from nats-io/release_2_9_4
Release v2.9.4
2022-10-27 16:35:51 -06:00
Ivan Kozlovic
f101e815fe Release v2.9.4
Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
2022-10-27 16:10:39 -06:00
Derek Collison
bd1df4bfd5 Bump to 2.9.4-RC.3
Signed-off-by: Derek Collison <derek@nats.io>
2022-10-27 13:21:08 -07:00
Derek Collison
95d91b2869 Merge pull request #3585 from nats-io/leaf-perms
[FIXED] Existing subs would be sent to leafnodes even though they violated permissions.
2022-10-27 15:19:48 -05:00
Ivan Kozlovic
2e2596916a Merge pull request #3587 from nats-io/add_pending_msgs_bytes_on_shutdown
Add the pending msgs/bytes on 409 Shutdown
2022-10-27 14:16:41 -06:00
Derek Collison
9bbf0aaaf0 Merge pull request #3586 from nats-io/client-update-2
Update Go client to release 1.19.0
2022-10-27 15:16:11 -05:00
Derek Collison
a746b578e7 Update Go client to release 1.19.0
Signed-off-by: Derek Collison <derek@nats.io>
2022-10-27 13:03:54 -07:00
Ivan Kozlovic
abcfe2e7ac Add the pending msgs/bytes on 409 Shutdown
This is related to PR #3572 and PR #3576

Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
2022-10-27 13:59:21 -06:00
Derek Collison
9c5ae6baef Existing subs would be sent to leafnodes even though pub perms should disallow.
If the LS+ gets through we debug that it was denied, but also fixed it so that does not happen.

Signed-off-by: Derek Collison <derek@nats.io>
2022-10-27 12:31:57 -07:00
Derek Collison
24081ae78e Bump to 2.9.4-RC.2
Signed-off-by: Derek Collison <derek@nats.io>
2022-10-27 09:19:22 -07:00
Derek Collison
c4847194ea Merge pull request #3584 from nats-io/update_client
Updated Go client
2022-10-27 11:18:04 -05:00
Derek Collison
d89992990b Merge pull request #3582 from nats-io/fix
Make sure to check for ss == nil
2022-10-27 11:07:11 -05:00
Ivan Kozlovic
6a2b59bf91 Merge pull request #3583 from nats-io/fix_3581
[FIXED] `allow_non_tls` is lost after server reload
2022-10-27 10:03:23 -06:00
Derek Collison
1a193fe8a6 Updated Go client
Signed-off-by: Derek Collison <derek@nats.io>
2022-10-27 08:55:43 -07:00
Derek Collison
8f6d55a878 Make sure to check for ss == nil
Signed-off-by: Derek Collison <derek@nats.io>
2022-10-27 08:52:42 -07:00
Ivan Kozlovic
b3e0431959 [FIXED] allow_non_tls is lost after server reload
The server would reset its INFO's TLSRequired to the presence
of a TLS configuration without checking for the allow_non_tls
option.

Resolves #3581

Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
2022-10-27 09:49:44 -06:00
Derek Collison
8cc87c988f Bump to 2.9.4-RC.1
Signed-off-by: Derek Collison <derek@nats.io>
2022-10-26 17:52:28 -07:00