Commit Graph

6589 Commits

Author SHA1 Message Date
Marco Primi
f8a030bc4a Use testing.TempDir() where possible
Refactor tests to use go built-in temporary directory utility for tests.

Also avoid binding to default port (which may be in use)
2022-12-12 13:18:44 -08:00
Derek Collison
dcd7ffdc4b Merge pull request #3704 from nats-io/issue-3703
Fix /healthz?js-enabled=true behavior
2022-12-10 07:32:47 -08:00
Byron Ruth
566d1adfa7 Fix /healthz?js-enabled=true behavior
When js-enabled is set to true, the condition was only checked if
the `getJetStream()` call returned `nil`. However, if it non-nil,
all remaining checks were executed, including assessing the health
of the assets (streams and consumers).

This change addresses two issues:

- Switch to use `js.isEnabled()` which will check whether the value
  is nil OR `js.disabled = true` which can occur if the subsystem
  is temporarily disabled (insufficient resources).
- Correctly exit the check after the assertion and before meta and
  asset checks are performed.

In addition, the option has been renamed to `js-enabled-only` to align
with the `js-server-only` naming. The previous `js-enabled` name still
works, but is mapped to this new option. A warning is emitted noting
the previous option is deprecated.

Fix #3703

Signed-off-by: Byron Ruth <b@devel.io>
2022-12-10 07:34:32 -05:00
Derek Collison
5b42cda4dd Merge pull request #3699 from nats-io/bump-2.9.10
Bump version to 2.9.10-dev
2022-12-08 09:51:43 -08:00
Byron Ruth
4352a17080 Bump version to 2.9.10-dev
Signed-off-by: Byron Ruth <b@devel.io>
2022-12-08 12:47:42 -05:00
Derek Collison
825949bc52 Merge pull request #3697 from nats-io/release-2.9.9
Prepare for next release
2022-12-08 09:24:53 -08:00
Byron Ruth
d8b9688567 Prepare for next release
Signed-off-by: Byron Ruth <b@devel.io>
2022-12-08 12:22:38 -05:00
Derek Collison
a0cbee426f Merge pull request #3696 from nats-io/go-1.19.4
Bump Travis to use Go 1.19.4
2022-12-08 09:17:29 -08:00
Byron Ruth
b19f0205e4 Bump Travis to use Go 1.19.4
Signed-off-by: Byron Ruth <b@devel.io>
2022-12-08 11:16:19 -05:00
Derek Collison
13edbeb0a8 Merge pull request #3694 from nats-io/test-3191
Extensive test in support of issue #3191.
2022-12-07 13:00:15 -08:00
Derek Collison
8c6418ee45 Extensive test in support of issue #3191.
Signed-off-by: Derek Collison <derek@nats.io>
2022-12-07 12:36:29 -08:00
Derek Collison
effccfd44e Merge pull request #3692 from Lawo-Ext/main
Fix for #3682 (Take 2): do not delay PINGs for GATEWAY or spoke LEAF connections
2022-12-07 08:27:18 -08:00
Sandy Kellagher
7907950a54 Fix for #3682: do not delay PINGs for GATEWAY or solicited LEAF connections, to ensure failover of leaf node connections 2022-12-07 16:19:33 +00:00
Derek Collison
5baf90265c Bump to v2.9.9-RC.1
Signed-off-by: Derek Collison <derek@nats.io>
2022-12-07 05:18:02 -08:00
Derek Collison
da2059a5f0 Merge pull request #3678 from nats-io/ut-replacepeer
tag policies not honored in reassignment after peer remove
2022-12-06 17:50:11 -08:00
Todd Beets
8021ee8db4 Merge pull request #3691 from nats-io/ut-test-fix-2
Make stream removal from a server consistent.
2022-12-06 17:39:23 -08:00
Derek Collison
2f27438230 Make stream removal from a server consistent.
Signed-off-by: Derek Collison <derek@nats.io>
2022-12-06 17:11:43 -08:00
Derek Collison
0a65d7960b Merge pull request #3690 from nats-io/upstream-jwt-acc-reenable
Fix to reenable JetStream for account when reenabled (dev → main)
2022-12-06 16:09:40 -08:00
Derek Collison
29b614a057 Fix flapping test
Signed-off-by: Derek Collison <derek@nats.io>
2022-12-06 16:08:45 -08:00
Waldemar Quevedo
6df92f40dc Fix to reenable JetStream for account when reenabled
Signed-off-by: Waldemar Quevedo <wally@nats.io>
2022-12-06 15:53:03 -08:00
Derek Collison
d410fce426 Merge pull request #3689 from nats-io/ghost-ephemerals
Ensure that consumers that are deleted on startup are removed from the system.
2022-12-06 15:39:41 -08:00
Derek Collison
549b77ca2d Ensure that ephemeral consumers that are deleted on startup properly are removed from the system.
Signed-off-by: Derek Collison <derek@nats.io>
2022-12-06 15:07:46 -08:00
Derek Collison
e847f9594b Merge pull request #3688 from nats-io/fix-3535
[FIXED] Fix for server panic when consumer state was not decoded correctly.
2022-12-06 14:27:30 -08:00
Derek Collison
894115b82b Fix for server panic when consumer state was not decoded correctly.
The bug was when a timestamp for the pending state was exactly -1 which could happen based on timing of the redlivered pending items which would set pending.Timestamp into the future potentially and the timing on the encodeConsumerState call.

Minor fixes to raft.

Signed-off-by: Derek Collison <derek@nats.io>
2022-12-06 14:16:20 -08:00
Todd Beets
bfd7d7f9ba improved test to remove false positive result 2022-12-06 12:48:53 -08:00
Todd Beets
3fdfb8a12f Merge branch 'main' into ut-replacepeer
# Conflicts:
#	server/jetstream_cluster_3_test.go
2022-12-06 10:51:22 -08:00
Todd Beets
2f61a9b128 Merge pull request #3681 from nats-io/ut-test-fix
Better test check form
2022-12-06 09:12:41 -08:00
Derek Collison
0cc4499537 Merge pull request #3683 from nats-io/update-signal-help
Update --signal usage help
2022-12-06 04:02:07 -08:00
Byron Ruth
d55ec395a3 Update --signal usage help
This includes `ldm` and `term`.

Signed-off-by: Byron Ruth <b@devel.io>
2022-12-06 06:45:00 -05:00
Derek Collison
65a833ccd9 Merge pull request #3680 from ripienaar/snapshot_full_state
Do not gather full state for snapshots
2022-12-06 03:31:17 -08:00
Derek Collison
74c373233f Update to test
Signed-off-by: Derek Collison <derek@nats.io>
2022-12-05 17:32:52 -08:00
Derek Collison
7665787050 Merge pull request #3679 from nats-io/fix-3677
[FIXED] Multiple issues with concurrent stream create requests.
2022-12-05 16:19:23 -08:00
R.I.Pienaar
9bbc01384e Do not gather full state for snapshots
This avoids hust state outputs for streams with many
deleted items

Signed-off-by: R.I.Pienaar <rip@devco.net>
2022-12-05 22:05:12 +01:00
Todd Beets
ef27d4d534 tag policies not honored in reassignment after peer remove 2022-12-04 20:39:11 -08:00
Derek Collison
5f7c8e21a2 Fixed issues with multiple concurrent stream create requests.
First issue was applications not getting any response.
However, there was also a more serious issue that would create multiple raft groups for each concurrent request.
The servers would only run one stream monitor loop, however they would update the state to the new raft group's name, so on server restart the stream would be using a different raft group then existing servers.

Signed-off-by: Derek Collison <derek@nats.io>
2022-12-04 19:13:51 -08:00
Derek Collison
c4c8761293 Merge pull request #3675 from mprimi/adjust_js_bench_min_work
Adjust minimum workload of JetStream benchmarks
2022-12-02 15:52:50 -08:00
Marco Primi
f20101370c Adjust minimum operations for JetStream benchmarks
Lower minimum amount of data / number of operations so that benchmarks 
can run in reasonable time.

Minimum amount of work should be controlled via `-benchtime` flag. But 
due to these hardcoded limits, some tests were taking too long.

e.g. Running for 2 minutes even with `-benchtime` set to 1 second.
2022-12-02 15:29:34 -08:00
Derek Collison
0c2727eef2 Merge pull request #3667 from nats-io/op-no-auth
[FIXED] Operator Mode could return no_auth_required set to false on client connect.
2022-11-25 11:09:41 -08:00
Derek Collison
a5814dad1f In operator mode do not set a no_auth_user for $G.
Signed-off-by: Derek Collison <derek@nats.io>
2022-11-25 10:20:35 -08:00
Derek Collison
6f616c57ca Bump to v2.9.9-beta as per release process
Signed-off-by: Derek Collison <derek@nats.io>
2022-11-22 13:00:03 -08:00
Derek Collison
60e335aaee Merge pull request #3662 from nats-io/release_2_9_8
Release v2.9.8
2022-11-22 12:37:55 -08:00
Derek Collison
03a5f20080 Release v2.9.8
Signed-off-by: Derek Collison <derek@nats.io>
2022-11-22 12:29:31 -08:00
Derek Collison
6bdc2b3f8a Merge pull request #3659 from nats-io/no_auth_user
If no_auth_user is set, clear auth required from server info to client.
2022-11-21 22:22:28 -08:00
Derek Collison
06bab2c4de If no_auth_user is set, clear auth required for server info.
Signed-off-by: Derek Collison <derek@nats.io>
2022-11-21 20:26:54 -08:00
Derek Collison
b45b439ad5 Merge pull request #3658 from nats-io/fix-3657
[FIXED] Server might crash on pull consumer delete.
2022-11-21 15:51:25 -08:00
Derek Collison
5e8c1993cb Server might crash if a pull consumer with inactivity threshold acks a msg then immediately deletes the consumer.
Signed-off-by: Derek Collison <derek@nats.io>
2022-11-21 15:22:23 -08:00
Ivan Kozlovic
dde34cea54 Bump to v2.9.8-beta as per release process
Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
2022-11-17 10:14:37 -07:00
Ivan Kozlovic
1e76678ca7 Merge pull request #3650 from nats-io/release_2_9_7
Release v2.9.7
2022-11-17 09:48:29 -07:00
Ivan Kozlovic
4765ea616f Release v2.9.7
Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
2022-11-17 09:45:08 -07:00
Derek Collison
97742f2fdc Merge pull request #3649 from nats-io/fix-3645-2
[FIXED] Make sure header keys do not have additional prefixes.
2022-11-17 07:27:19 -08:00