64e3bf82ed
PR https://github.com/nats-io/nats-server/pull/4212 fixed the issue I reported in https://github.com/nats-io/nats-server/issues/4196. However, I believe there might be a bug when both `sequence` and `keep` are set during recovery. In the `PurgeEx` the following check is done (for both `filestore.go` and `memstore.go`): ```go if sequence > 1 && keep > 0 { return 0, ErrPurgeArgMismatch } ``` The `TestJetStreamClusterPurgeExReplayAfterRestart` also triggers this case, meaning that during the test this error is returned but it succeeds because the purge was already performed. Is this intended behaviour? To elaborate a bit more, I believe the following happens: - when running the purge normally it will properly run the `keep` (since it's not combined with `sequence` yet) - when replaying the purge though, the `sequence` is added to the `keep`, which errors out in the above if Which means that during normal operation all will be well, but purges with `keep` will be ignored upon replaying. I'm proposing to remove the `sequence > 1 && keep > 0` check and subsequent error. Which, for reference, was introduced in https://github.com/nats-io/nats-server/pull/3121. Hoping this ensures that during recovery, purges that haven't executed yet will still be executed. An alternative approach, which wouldn't remove the error: not allow combining `sequence` and `keep` normally and only allowing it during recovery. Which would preserve the current behaviour, and correctly apply `sequence+keep` during recovery still. However, not sure if it's possible to know if we're in "recovery mode" from within `PurgeEx`. Resolves https://github.com/nats-io/nats-server/issues/4196
NATS is a simple, secure and performant communications system for digital systems, services and devices. NATS is part of the Cloud Native Computing Foundation (CNCF). NATS has over 40 client language implementations, and its server can run on-premise, in the cloud, at the edge, and even on a Raspberry Pi. NATS can secure and simplify design and operation of modern distributed systems.
Documentation
- Official Website
- Official Documentation
- FAQ
- Watch a video overview of NATS.
- Watch this video from SCALE 13x to learn more about its origin story and design philosophy.
Contact
- Twitter: Follow us on Twitter!
- Google Groups: Where you can ask questions
- Slack: Click here to join. You can ask question to our maintainers and to the rich and active community.
Contributing
If you are interested in contributing to NATS, read about our...
Roadmap
The NATS product roadmap can be found here.
Security
Security Audit
A third party security audit was performed by Cure53, you can see the full report here.
Reporting Security Vulnerabilities
If you've found a vulnerability or a potential vulnerability in the NATS server, please let us know at nats-security.
License
Unless otherwise noted, the NATS source files are distributed under the Apache Version 2.0 license found in the LICENSE file.