mirror of
https://github.com/gogrlx/nats-server.git
synced 2026-04-17 03:24:40 -07:00
b61e411b44
Fixes the following race: during reload account sublist can be changed:2699465596/server/reload.go (L1598-L1610)so this can become a race while checking interest in the gateway code here:79de3302be/server/gateway.go (L2683)``` === RUN TestJetStreamSuperClusterPeerReassign ================== WARNING: DATA RACE Write at 0x00c0010854f0 by goroutine 15595: github.com/nats-io/nats-server/v2/server.(*Server).reloadAuthorization.func2() /home/travis/gopath/src/github.com/nats-io/nats-server/server/reload.go:1610 +0x486 sync.(*Map).Range() /home/travis/.gimme/versions/go1.19.8.linux.amd64/src/sync/map.go:354 +0x225 github.com/nats-io/nats-server/v2/server.(*Server).reloadAuthorization() /home/travis/gopath/src/github.com/nats-io/nats-server/server/reload.go:1594 +0x35d github.com/nats-io/nats-server/v2/server.(*Server).applyOptions() /home/travis/gopath/src/github.com/nats-io/nats-server/server/reload.go:1454 +0xf4 github.com/nats-io/nats-server/v2/server.(*Server).reloadOptions() /home/travis/gopath/src/github.com/nats-io/nats-server/server/reload.go:908 +0x204 github.com/nats-io/nats-server/v2/server.(*Server).ReloadOptions() /home/travis/gopath/src/github.com/nats-io/nats-server/server/reload.go:847 +0x4a4 github.com/nats-io/nats-server/v2/server.(*Server).Reload() /home/travis/gopath/src/github.com/nats-io/nats-server/server/reload.go:782 +0x125 github.com/nats-io/nats-server/v2/server.(*cluster).removeJetStream() /home/travis/gopath/src/github.com/nats-io/nats-server/server/jetstream_helpers_test.go:1498 +0x310 github.com/nats-io/nats-server/v2/server.TestJetStreamSuperClusterPeerReassign() /home/travis/gopath/src/github.com/nats-io/nats-server/server/jetstream_super_cluster_test.go:395 +0xa38 testing.tRunner() /home/travis/.gimme/versions/go1.19.8.linux.amd64/src/testing/testing.go:1446 +0x216 testing.(*T).Run.func1() /home/travis/.gimme/versions/go1.19.8.linux.amd64/src/testing/testing.go:1493 +0x47 Previous read at 0x00c0010854f0 by goroutine 15875: github.com/nats-io/nats-server/v2/server.(*Server).gatewayHandleSubjectNoInterest() /home/travis/gopath/src/github.com/nats-io/nats-server/server/gateway.go:2683 +0x12d github.com/nats-io/nats-server/v2/server.(*client).processInboundGatewayMsg() /home/travis/gopath/src/github.com/nats-io/nats-server/server/gateway.go:2980 +0x595 github.com/nats-io/nats-server/v2/server.(*client).processInboundMsg() /home/travis/gopath/src/github.com/nats-io/nats-server/server/client.go:3532 +0xc7 github.com/nats-io/nats-server/v2/server.(*client).parse() /home/travis/gopath/src/github.com/nats-io/nats-server/server/parser.go:497 +0x34f9 github.com/nats-io/nats-server/v2/server.(*client).readLoop() /home/travis/gopath/src/github.com/nats-io/nats-server/server/client.go:1284 +0x17e8 github.com/nats-io/nats-server/v2/server.(*Server).createGateway.func1() /home/travis/gopath/src/github.com/nats-io/nats-server/server/gateway.go:858 +0x37 Goroutine 15595 (running) created at: testing.(*T).Run() /home/travis/.gimme/versions/go1.19.8.linux.amd64/src/testing/testing.go:1493 +0x75d testing.runTests.func1() /home/travis/.gimme/versions/go1.19.8.linux.amd64/src/testing/testing.go:1846 +0x99 testing.tRunner() /home/travis/.gimme/versions/go1.19.8.linux.amd64/src/testing/testing.go:1446 +0x216 testing.runTests() /home/travis/.gimme/versions/go1.19.8.linux.amd64/src/testing/testing.go:1844 +0x7ec testing.(*M).Run() /home/travis/.gimme/versions/go1.19.8.linux.amd64/src/testing/testing.go:1726 +0xa84 github.com/nats-io/nats-server/v2/server.TestMain() /home/travis/gopath/src/github.com/nats-io/nats-server/server/sublist_test.go:1577 +0x292 main.main() _testmain.go:3615 +0x324 Goroutine 15875 (running) created at: github.com/nats-io/nats-server/v2/server.(*Server).startGoRoutine() /home/travis/gopath/src/github.com/nats-io/nats-server/server/server.go:3098 +0x88 github.com/nats-io/nats-server/v2/server.(*Server).createGateway() /home/travis/gopath/src/github.com/nats-io/nats-server/server/gateway.go:858 +0xfc4 github.com/nats-io/nats-server/v2/server.(*Server).startGatewayAcceptLoop.func1() /home/travis/gopath/src/github.com/nats-io/nats-server/server/gateway.go:553 +0x48 github.com/nats-io/nats-server/v2/server.(*Server).acceptConnections.func1() /home/travis/gopath/src/github.com/nats-io/nats-server/server/server.go:2184 +0x58 ================== testing.go:1319: race detected during execution of test --- FAIL: TestJetStreamSuperClusterPeerReassign (2.08s) ```
NATS is a simple, secure and performant communications system for digital systems, services and devices. NATS is part of the Cloud Native Computing Foundation (CNCF). NATS has over 40 client language implementations, and its server can run on-premise, in the cloud, at the edge, and even on a Raspberry Pi. NATS can secure and simplify design and operation of modern distributed systems.
Documentation
- Official Website
- Official Documentation
- FAQ
- Watch a video overview of NATS.
- Watch this video from SCALE 13x to learn more about its origin story and design philosophy.
Contact
- Twitter: Follow us on Twitter!
- Google Groups: Where you can ask questions
- Slack: Click here to join. You can ask question to our maintainers and to the rich and active community.
Contributing
If you are interested in contributing to NATS, read about our...
Roadmap
The NATS product roadmap can be found here.
Security
Security Audit
A third party security audit was performed by Cure53, you can see the full report here.
Reporting Security Vulnerabilities
If you've found a vulnerability or a potential vulnerability in the NATS server, please let us know at nats-security.
License
Unless otherwise noted, the NATS source files are distributed under the Apache Version 2.0 license found in the LICENSE file.