b7c61cd0bf
The filestore would release a msgBlock lock while trying to load a cache block if it thought it needed to flush pending data. With async false, this should be very rare but was possible after careful inspection. I constructed an artificial test with sleeps throughout the filestore code to reproduce. It involved having 2 Go routines that were through and waiting on the last msg block, and another one that was writing. After the write, but before we flushed after releasing the lock we would also artificially sleep. This would lead to the second read seeing the cache load was already in progress and return no error. If the load was for a sequence before the current write sequence, and async was false, the cache fseq would be higher than what was requested. This would cause the errPartialCache to be returned. Once returned to the consumer level in loopAndGather, it would exit that Go routine and the consumer would cease to function. This change removed the unlock of a msgBlock to perform and flush, ensuring that two cacheLoads would not yield the errPartialCache. I also updated the consumer in the case this does happen in the future to not exit the loopAndGather Go routine. Signed-off-by: Derek Collison <derek@nats.io>
NATS is a simple, secure and performant communications system for digital systems, services and devices. NATS is part of the Cloud Native Computing Foundation (CNCF). NATS has over 40 client language implementations, and its server can run on-premise, in the cloud, at the edge, and even on a Raspberry Pi. NATS can secure and simplify design and operation of modern distributed systems.
Documentation
- Official documentation
- FAQ
- Watch a video overview of NATS to learn more about its origin story and design philosophy.
Contact
- Twitter: Follow us on Twitter!
- Google Groups: Where you can ask questions
- Slack: Click here to join. You can ask question to our maintainers and to the rich and active community.
Contributing
If you are interested in contributing to NATS, read about our...
Security
Security Audit
A third party security audit was performed by Cure53, you can see the full report here.
Reporting Security Vulnerabilities
If you've found a vulnerability or a potential vulnerability in the NATS server, please let us know at nats-security.
License
Unless otherwise noted, the NATS source files are distributed under the Apache Version 2.0 license found in the LICENSE file.