eff27e26be
The test shows the issue. It seems that Consumer.needAck() for AckExplicit should consider that an Ack is needed if sseq > o.asflr and there is no pending ack at all. However making this change would break the test TestJetStreamInterestRetentionStream. Also, running the new test with `-count 100` and by adding an artificial delay in stream.ackMsg() (just before calling mset.store.RemoveMsg(seq)) causes sometimes delete requests for the same sequence to be processed twice, which causes the new test to fail (even with an attempted fix as discussed above). I think that the attempt to remove the same sequence twice is messing up the state. Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
NATS is a simple, secure and performant communications system for digital systems, services and devices. NATS is part of the Cloud Native Computing Foundation (CNCF). NATS has over 30 client language implementations, and its server can run on-premise, in the cloud, at the edge, and even on a Raspberry Pi. NATS can secure and simplify design and operation of modern distributed systems.
Documentation
- Official documentation
- FAQ
- Watch a video overview of NATS to learn more about its origin story and design philosophy.
Contact
- Twitter: Follow us on Twitter!
- Google Groups: Where you can ask questions
- Slack: Click here to join. You can ask question to our maintainers and to the rich and active community.
Contributing
If you are interested in contributing to NATS, read about our...
Security
Security Audit
A third party security audit was performed by Cure53, you can see the full report here.
Reporting Security Vulnerabilities
If you've found a vulnerability or a potential vulnerability in the NATS server, please let us know at nats-security.
License
Unless otherwise noted, the NATS source files are distributed under the Apache Version 2.0 license found in the LICENSE file.