gogrlx/snack
1
0
Fork 0
mirror of https://github.com/gogrlx/snack.git synced 2026-04-02 05:08:42 -07:00
Code Issues Packages Projects Releases Wiki Activity

fix: update apt/dpkg integration tests for 2-value Install/Remove returns

Browse Source
This commit is contained in:
Tai Groot
2026-03-01 01:44:50 +00:00
parent 4e90abc6a3
commit f85e215981
2 changed files with 10 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
apt/apt_integration_test.go
View File

@@ -75,9 +75,9 @@ func TestIntegration_Apt(t *testing.T) {
t.Run("Install_Single", func(t *testing.T) {
// Remove first to ensure clean state
_, _, _ = mgr.Remove(ctx, snack.Targets("tree"), snack.WithAssumeYes())
_, _ = mgr.Remove(ctx, snack.Targets("tree"), snack.WithAssumeYes())
_, _, err := mgr.Install(ctx, snack.Targets("tree"), snack.WithAssumeYes())
_, err := mgr.Install(ctx, snack.Targets("tree"), snack.WithAssumeYes())
require.NoError(t, err)
})
@@ -127,7 +127,7 @@ func TestIntegration_Apt(t *testing.T) {
ver, err := mgr.Version(ctx, "tree")
require.NoError(t, err)
_, _, err = mgr.Install(ctx, []snack.Target{{Name: "tree", Version: ver}}, snack.WithAssumeYes())
_, err = mgr.Install(ctx, []snack.Target{{Name: "tree", Version: ver}}, snack.WithAssumeYes())
// Should succeed (already installed at that version) or be a no-op
// Some apt versions may return success, others may note it's already installed
_ = err
@@ -135,7 +135,7 @@ func TestIntegration_Apt(t *testing.T) {
t.Run("Purge", func(t *testing.T) {
// Install then purge (removes config files too)
_, _, _ = mgr.Install(ctx, snack.Targets("tree"), snack.WithAssumeYes())
_, _ = mgr.Install(ctx, snack.Targets("tree"), snack.WithAssumeYes())
err := mgr.Purge(ctx, snack.Targets("tree"), snack.WithAssumeYes())
require.NoError(t, err)
@@ -145,7 +145,7 @@ func TestIntegration_Apt(t *testing.T) {
})
t.Run("Install_Multiple", func(t *testing.T) {
_, _, err := mgr.Install(ctx, snack.Targets("tree", "less"), snack.WithAssumeYes())
_, err := mgr.Install(ctx, snack.Targets("tree", "less"), snack.WithAssumeYes())
require.NoError(t, err)
for _, pkg := range []string{"tree", "less"} {
@@ -156,7 +156,7 @@ func TestIntegration_Apt(t *testing.T) {
})
t.Run("Remove", func(t *testing.T) {
_, _, err := mgr.Remove(ctx, snack.Targets("tree"), snack.WithAssumeYes())
_, err := mgr.Remove(ctx, snack.Targets("tree"), snack.WithAssumeYes())
require.NoError(t, err)
installed, err := mgr.IsInstalled(ctx, "tree")
@@ -223,7 +223,7 @@ func TestIntegration_Apt(t *testing.T) {
require.True(t, ok, "apt must implement Holder")
// Ensure tree is installed for hold tests
_, _, _ = mgr.Install(ctx, snack.Targets("tree"), snack.WithAssumeYes())
_, _ = mgr.Install(ctx, snack.Targets("tree"), snack.WithAssumeYes())
t.Run("Hold", func(t *testing.T) {
err := h.Hold(ctx, []string{"tree"})
@@ -287,7 +287,7 @@ func TestIntegration_Apt(t *testing.T) {
require.True(t, ok, "apt must implement FileOwner")
// Ensure tree is installed
_, _, _ = mgr.Install(ctx, snack.Targets("tree"), snack.WithAssumeYes())
_, _ = mgr.Install(ctx, snack.Targets("tree"), snack.WithAssumeYes())
t.Run("FileList", func(t *testing.T) {
files, err := fo.FileList(ctx, "tree")
@@ -379,5 +379,5 @@ func TestIntegration_Apt(t *testing.T) {
})
// Cleanup
_, _, _ = mgr.Remove(ctx, snack.Targets("tree", "less"), snack.WithAssumeYes())
_, _ = mgr.Remove(ctx, snack.Targets("tree", "less"), snack.WithAssumeYes())
}

2
dpkg/dpkg_integration_test.go
View File

@@ -164,7 +164,7 @@ func TestIntegration_Dpkg(t *testing.T) {
t.Run("Install_Unsupported", func(t *testing.T) {
// dpkg install requires a .deb file path, not a package name
// This should fail gracefully
_, _, err := mgr.Install(ctx, snack.Targets("tree"))
_, err := mgr.Install(ctx, snack.Targets("tree"))
assert.Error(t, err)
})