test: fix TestFileStoreNewWriteIndexInfo hanging

t.Fatalf being called while holding a lock would
sometimes leave builds hanging.

Signed-off-by: Waldemar Quevedo <wally@nats.io>
This commit is contained in:
Waldemar Quevedo
2023-08-08 16:41:10 -07:00
parent 961c0d7187
commit 1492cf717f

View File

@@ -5478,9 +5478,16 @@ func TestFileStoreNewWriteIndexInfo(t *testing.T) {
mb.mu.Lock()
start := time.Now()
require_NoError(t, mb.writeIndexInfoLocked())
err = mb.writeIndexInfoLocked()
if err != nil {
mb.mu.Unlock()
t.Fatalf("Unexpected error: %v", err)
}
elapsed := time.Since(start)
require_True(t, elapsed < time.Millisecond)
if elapsed > time.Millisecond {
mb.mu.Unlock()
t.Fatalf("Unexpected elapsed time: %v", elapsed)
}
fi, err := os.Stat(mb.ifn)
mb.mu.Unlock()