gogrlx/nats-server
1
0
Fork 0
mirror of https://github.com/gogrlx/nats-server.git synced 2026-04-02 03:38:42 -07:00
Code Issues Packages Projects Releases Wiki Activity

test: fix TestFileStoreNewWriteIndexInfo hanging (#4378)

Browse Source 
`t.Fatalf` being called while holding a lock would sometimes leave
builds hanging until test timeout.

```
=== RUN   TestFileStoreNewWriteIndexInfo/AES-GCM-None
=== RUN   TestFileStoreNewWriteIndexInfo/AES-GCM-S2
    filestore_test.go:5483: require true, but got false
No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.
```
This commit is contained in:
Waldemar Quevedo
2023-08-08 17:40:24 -07:00
committed by GitHub
parent 961c0d7187 1492cf717f
commit 6703bd7ee3
1 changed files with 9 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
server/filestore_test.go
View File

@@ -5478,9 +5478,16 @@ func TestFileStoreNewWriteIndexInfo(t *testing.T) {
mb.mu.Lock()
start := time.Now()
require_NoError(t, mb.writeIndexInfoLocked())
err = mb.writeIndexInfoLocked()
if err != nil {
mb.mu.Unlock()
t.Fatalf("Unexpected error: %v", err)
}
elapsed := time.Since(start)
require_True(t, elapsed < time.Millisecond)
if elapsed > time.Millisecond {
mb.mu.Unlock()
t.Fatalf("Unexpected elapsed time: %v", elapsed)
}
fi, err := os.Stat(mb.ifn)
mb.mu.Unlock()